Opened 2 years ago

Closed 7 months ago

#23359 closed defect (fixed)

WebExtensions icons are not shown on first start but on restart

Reported by: gk Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: AffectsTails, TorBrowserTeam201903
Cc: tbb-team, boklm, legind, Dbryrtfbcbhgf, tseretni-rmd, rustybird@…, intrigeri Actual Points:
Parent ID: #25658 Points:
Reviewer: Sponsor:

Description

When testing the release candidate for 7.0.5 I realized that with the WebExtensions-based HTTPS-Everywhere the icon is not shown anymore on the toolbar on first start. After a restart it is visible again.

Child Tickets

Change History (17)

comment:1 Changed 2 years ago by gk

Cc: legind added
Summary: HTTPS-Everywhere icon is not shown on first startHTTPS-Everywhere icon is not shown on first start but on restart

browser.uiCustomization.state contains https-everywhere-button in the nav-bar key right from the beginning on my machine if the XPCOM version is installed. But not with the WebExtensions-based add-on. On restart, when the icon is visible, https-everywhere-eff_eff_org-browser-action is shown as value in nav-bar. Not sure where this is coming from. I guess we could think about the general intended behavior while redoing our toolbar design (see: #23151).

comment:2 in reply to:  description ; Changed 2 years ago by cypherpunks

Status: newneeds_information

Replying to gk:

WebExtensions-based HTTPS-Everywhere

It is a legacy Embedded WebExtension, "Add-on SDK"-based. WebExtensions-based HTTPS-Everywhere will replace it for FF57.

Do you think it's a TBB issue?

comment:3 in reply to:  2 Changed 2 years ago by gk

Status: needs_informationassigned

Replying to cypherpunks:

Replying to gk:

WebExtensions-based HTTPS-Everywhere

It is a legacy Embedded WebExtension, "Add-on SDK"-based. WebExtensions-based HTTPS-Everywhere will replace it for FF57.

Do you think it's a TBB issue?

I see it happen in Tor Browser but not in Firefox. I might not have tested hard enough in the Firefox case, though.

comment:4 Changed 2 years ago by cypherpunks

Besides other errors, it has

1504252203300	addons.xpi	WARN	Add-on https-everywhere-eff@eff.org is missing bootstrap method uninstall
1504252203300	addons.xpi	WARN	Add-on https-everywhere-eff@eff.org is missing bootstrap method install
Bootstrapped manifest not allowed to use 'component' directive.  chrome.manifest:60
Bootstrapped manifest not allowed to use 'contract' directive.  chrome.manifest:61
Bootstrapped manifest not allowed to use 'category' directive.  chrome.manifest:63
Bootstrapped manifest not allowed to use 'overlay' directive.  chrome.manifest:68
Bootstrapped manifest not allowed to use 'overlay' directive.  chrome.manifest:69
Bootstrapped manifest not allowed to use 'style' directive.  chrome.manifest:71
Bootstrapped manifest not allowed to use 'component' directive.  chrome.manifest:74
Bootstrapped manifest not allowed to use 'contract' directive.  chrome.manifest:75
Bootstrapped manifest not allowed to use 'category' directive.  chrome.manifest:76

where 'overlay' directives are

overlay chrome://browser/content/browser.xul chrome://https-everywhere/content/toolbar_button.xul application={ec8030f7-c20a-464f-9b0e-13a3a9e97384} application={92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a} application={3550f703-e582-4d05-9a08-453d09bdfdc6} application={a79fe89b-6662-4ff4-8e88-09950ad4dfde}
overlay chrome://navigator/content/navigator.xul chrome://https-everywhere/content/toolbar_button.xul application={ec8030f7-c20a-464f-9b0e-13a3a9e97384} application={92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a} application={3550f703-e582-4d05-9a08-453d09bdfdc6} application={a79fe89b-6662-4ff4-8e88-09950ad4dfde}

FF57 is on nightly now, so it seems they'll switch to a WebExtension instead of fixing this.

comment:5 Changed 2 years ago by gk

Cc: Dbryrtfbcbhgf added

#23400 is a duplicate.

comment:6 Changed 2 years ago by cypherpunks

Without e10s:

18:39:43.555 NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIDOMWindowUtils.isParentWindowMainWidgetVisible] 1 nsPrompter.js:350

comment:7 Changed 18 months ago by tseretni-rmd

Cc: tseretni-rmd added

comment:8 Changed 16 months ago by gk

Cc: rustybird@… added
Summary: HTTPS-Everywhere icon is not shown on first start but on restartWebExtensions icons are not shown on first start but on restart

Resolveed #26501 as duplicate.

comment:9 Changed 16 months ago by cypherpunks

Keywords: ff60-esr added

Happens on ff60-esr as well.

comment:10 in reply to:  9 Changed 16 months ago by cypherpunks

Replying to cypherpunks:

Happens on ff60-esr as well.

But not after ff52-esr -> ff60-esr update, fwiw.

comment:11 Changed 16 months ago by intrigeri

Cc: intrigeri added

comment:12 Changed 16 months ago by intrigeri

Keywords: AffectsTails added

Might this be related to the code guarded by extensions.torbutton.inserted_button in src/chrome/content/torbutton.js?

We've had workarounds for similar issues in Tails forever and they're not working anymore in 8.0 so I've dropped them and I'm now very interested in seeing this fixed for real in Tor Browser :)

comment:13 Changed 16 months ago by gk

Priority: MediumHigh

comment:14 Changed 14 months ago by gk

Keywords: ff60-esr removed
Priority: HighMedium

Not that important for Tails and not a Firefox 60 issue.

comment:15 Changed 9 months ago by arma

#28975 was closed as a duplicate.

comment:16 Changed 7 months ago by pospeselr

Cc: tbb-team added
Owner: changed from tbb-team to pospeselr
Parent ID: #25658

comment:17 Changed 7 months ago by gk

Keywords: TorBrowserTeam201903 added
Resolution: fixed
Status: assignedclosed

Fixed by #25658, closing.

Note: See TracTickets for help on using tickets.