WebExtensions icons are not shown on first start but on restart

added AffectsTails TorBrowserTeam201903 component::applications/tor browser owner::pospeselr parent::25658 priority::medium resolution::fixed severity::normal status::closed type::defect labels

browser.uiCustomization.state contains https-everywhere-button in the nav-bar key right from the beginning on my machine if the XPCOM version is installed. But not with the WebExtensions-based add-on. On restart, when the icon is visible, https-everywhere-eff_eff_org-browser-action is shown as value in nav-bar. Not sure where this is coming from. I guess we could think about the general intended behavior while redoing our toolbar design (see: #23151 (moved)).

Trac:
Cc: boklm to boklm, legind
Summary: HTTPS-Everywhere icon is not shown on first start to HTTPS-Everywhere icon is not shown on first start but on restart

Replying to gk:

WebExtensions-based HTTPS-Everywhere It is a legacy Embedded WebExtension, "Add-on SDK"-based. WebExtensions-based HTTPS-Everywhere will replace it for FF57.

Do you think it's a TBB issue?

Trac:
Status: new to needs_information

Replying to cypherpunks:

Replying to gk:

WebExtensions-based HTTPS-Everywhere It is a legacy Embedded WebExtension, "Add-on SDK"-based. WebExtensions-based HTTPS-Everywhere will replace it for FF57.

Do you think it's a TBB issue?

I see it happen in Tor Browser but not in Firefox. I might not have tested hard enough in the Firefox case, though.

Trac:
Status: needs_information to assigned

Besides other errors, it has

1504252203300	addons.xpi	WARN	Add-on https-everywhere-eff@eff.org is missing bootstrap method uninstall
1504252203300	addons.xpi	WARN	Add-on https-everywhere-eff@eff.org is missing bootstrap method install
Bootstrapped manifest not allowed to use 'component' directive.  chrome.manifest:60
Bootstrapped manifest not allowed to use 'contract' directive.  chrome.manifest:61
Bootstrapped manifest not allowed to use 'category' directive.  chrome.manifest:63
Bootstrapped manifest not allowed to use 'overlay' directive.  chrome.manifest:68
Bootstrapped manifest not allowed to use 'overlay' directive.  chrome.manifest:69
Bootstrapped manifest not allowed to use 'style' directive.  chrome.manifest:71
Bootstrapped manifest not allowed to use 'component' directive.  chrome.manifest:74
Bootstrapped manifest not allowed to use 'contract' directive.  chrome.manifest:75
Bootstrapped manifest not allowed to use 'category' directive.  chrome.manifest:76

where 'overlay' directives are

overlay chrome://browser/content/browser.xul chrome://https-everywhere/content/toolbar_button.xul application={ec8030f7-c20a-464f-9b0e-13a3a9e97384} application={92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a} application={3550f703-e582-4d05-9a08-453d09bdfdc6} application={a79fe89b-6662-4ff4-8e88-09950ad4dfde}
overlay chrome://navigator/content/navigator.xul chrome://https-everywhere/content/toolbar_button.xul application={ec8030f7-c20a-464f-9b0e-13a3a9e97384} application={92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a} application={3550f703-e582-4d05-9a08-453d09bdfdc6} application={a79fe89b-6662-4ff4-8e88-09950ad4dfde}

FF57 is on nightly now, so it seems they'll switch to a WebExtension instead of fixing this.

#23400 (moved) is a duplicate.

Trac:
Cc: boklm, legind to boklm, legind, Dbryrtfbcbhgf

Without e10s:

18:39:43.555 NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIDOMWindowUtils.isParentWindowMainWidgetVisible] 1 nsPrompter.js:350

Trac:
Username: tseretni-rmd
Cc: boklm, legind, Dbryrtfbcbhgf to boklm, legind, Dbryrtfbcbhgf, tseretni-rmd

Resolveed #26501 (moved) as duplicate.

Trac:
Cc: boklm, legind, Dbryrtfbcbhgf, tseretni-rmd to boklm, legind, Dbryrtfbcbhgf, tseretni-rmd, rustybird@net-c.com
Summary: HTTPS-Everywhere icon is not shown on first start but on restart to WebExtensions icons are not shown on first start but on restart

Happens on ff60-esr as well.

Trac:
Keywords: N/A deleted, ff60-esr added

Replying to cypherpunks:

Happens on ff60-esr as well. But not after ff52-esr -> ff60-esr update, fwiw.

Trac:
Cc: boklm, legind, Dbryrtfbcbhgf, tseretni-rmd, rustybird@net-c.com to boklm, legind, Dbryrtfbcbhgf, tseretni-rmd, rustybird@net-c.com, intrigeri

Might this be related to the code guarded by extensions.torbutton.inserted_button in src/chrome/content/torbutton.js?

We've had workarounds for similar issues in Tails forever and they're not working anymore in 8.0 so I've dropped them and I'm now very interested in seeing this fixed for real in Tor Browser :)

Trac:
Keywords: N/A deleted, AffectsTails added

Trac:
Priority: Medium to High

Not that important for Tails and not a Firefox 60 issue.

Trac:
Keywords: ff60-esr deleted, N/A added
Priority: High to Medium

#28975 (moved) was closed as a duplicate.

Trac:
Parent: N/A to #25658 (moved)
Owner: tbb-team to pospeselr
Cc: boklm, legind, Dbryrtfbcbhgf, tseretni-rmd, rustybird@net-c.com, intrigeri to tbb-team, boklm, legind, Dbryrtfbcbhgf, tseretni-rmd, rustybird@net-c.com, intrigeri

Fixed by #25658 (moved), closing.

Trac:
Status: assigned to closed
Resolution: N/A to fixed
Keywords: N/A deleted, TorBrowserTeam201903 added

closed

mentioned in issue #23400 (moved)

WebExtensions icons are not shown on first start but on restart

Child items 0

Activity