prop224: Service has dead code which removed a feature
It appears that hs_service_dir_info_changed()
has become unused after the massive merge of #20657 (moved) which was replaced by hs_hsdir_set_changed_consider_reupload()
but then the consider_hsdir_upload_retry()
is not used anymore.
That feature was about retrying to HSDir for which when we want to upload to, we are missing a descriptor. That is not possible to happen anymore because in order to compute the HSDir index, the descriptor is needed thus mandatory to have in order to learn if the HSDir is the correct one we need on the hashring.
The fix here is to use hs_service_dir_info_changed()
in nodelist.c
and make it do what hs_hsdir_set_changed_consider_reupload()
does. And remove the hsdir_missing_info
feature.