Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#23364 closed defect (worksforme)

RBM_NUM_PROCS not respected

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by arthuredelstein)

I tried using the RBM_NUM_PROCS option (implemented in #23075) with tor-browser-build. Unfortunately the build continued to use the default 4 cores for some reason.

If I replace the line

 num_procs: '[% GET ENV.RBM_NUM_PROCS ? ENV.RBM_NUM_PROCS : "4" %]'

with

 num_procs: '[% GET ENV.RBM_NUM_PROCS ? ENV.RBM_NUM_PROCS : "32" %]'

then it uses 32 cores as the default. So somehow the RBM_NUM_PROCS env var is not being detected.

Child Tickets

Change History (8)

comment:1 Changed 2 years ago by arthuredelstein

Description: modified (diff)

comment:2 Changed 2 years ago by cypherpunks

Status: newneeds_information

CORES or PROCS?

comment:3 Changed 2 years ago by boklm

You can check if the value of buildconf/num_procs is correctly set with ./rbm/rbm showconf tor buildconf/num_procs.

This is what I have:

$ ./rbm/rbm showconf tor buildconf/num_procs
4
$ RBM_NUM_PROCS=32 ./rbm/rbm showconf tor buildconf/num_procs
32

comment:4 Changed 2 years ago by arthuredelstein

Description: modified (diff)
Resolution: worksforme
Status: needs_informationclosed
Summary: RBM_NUM_CORES not respectedRBM_NUM_PROCS not respected

OK, false alarm. Turns out my problem was that I set env var with my user account, but then called sudo make alpha. The env var is not preserved when I use sudo. Thanks, boklm!

comment:5 Changed 2 years ago by boklm

Ah,ok. But why are you running it with sudo?

comment:6 Changed 2 years ago by arthuredelstein

In general I was running into errors when I didn't use sudo. I recall it had something to do with running the container. It's possible that I need to wipe the whole directory and start again without sudo -- should that work?

comment:7 Changed 2 years ago by boklm

Yes, it should work without using sudo (at least it works for me). If it doesn't, it is probably something we should fix.

Commit 86210c6821e393e98dd58c7d7bb6223755b496d5 fixed some permission issues on some systems when running the containers, so maybe you were affected by that.

comment:8 Changed 2 years ago by arthuredelstein

Thanks -- I will give it a try at some point and let you know if I still have trouble.

Note: See TracTickets for help on using tickets.