Opened 2 years ago

Closed 2 years ago

#23366 closed defect (fixed)

test: test_options_validate__outbound_addresses is broken

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-test
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Turns out that test_options_validate__outbound_addresses() tries to test a bad OutboundBindAddress option and thus expects options_validate() to return -1.

However, in options_validate():

  if (parse_outbound_addresses(options, 1, msg) < 0)
    return -1;

... but if you look at parse_outbound_addresses() it ONLY returns 0 so it's simply not working. Was added in with commit 81c78ec7556 which is tor-

options_act() also calls parse_outbound_addresses() in the same way.

Child Tickets

Change History (2)

comment:1 Changed 2 years ago by dgoulet

Status: newneeds_review

Branch: bug23366_032_01.

comment:2 Changed 2 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed


Note: See TracTickets for help on using tickets.