Opened 3 years ago

Closed 3 years ago

#23382 closed task (fixed)

rbm: Error when the tmp_dir directory does not exist

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201709R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


In the rbm build, we can define the temporary directory to use with the tmp_dir option. If we set it to a directory that does not exist yet, it fails with an error. We should instead try to create it if it does not exist.

Child Tickets

Attachments (1)

0001-Bug-23382-create-tmp_dir-if-it-does-not-exist.patch (4.0 KB) - added by boklm 3 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 3 years ago by boklm

Related to this, I'm wondering if we should default to using a tmp directory inside the tor-browser-build directory, rather than /tmp, as having a small /tmp directory (usually in a tmpfs) seems to be quite common.

comment:2 Changed 3 years ago by gk

I am a fan.

comment:3 Changed 3 years ago by boklm

I opened #23403 for that.

comment:4 Changed 3 years ago by boklm

Status: assignedneeds_review

I attached a patch for rbm.git creating the directory if it does not exist yet.

comment:5 Changed 3 years ago by boklm

Keywords: TorBrowserTeam201709R added; TorBrowserTeam201709 removed

comment:6 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. Applied to master (commit 296fba79fca70b922cc6eb2be8b830d8074b70e4) and I updated tor-browser-build to pick the new commit up (commit 6690281b7eec547ee4c977ae9fc89728f63c5016).

Note: See TracTickets for help on using tickets.