Opened 10 years ago

Closed 7 years ago

#2339 closed enhancement (fixed)

Torbutton Date hook parses dates incorrectly

Reported by: bee Owned by: mikeperry
Priority: Medium Milestone: TorBrowserBundle 2.2.x-stable
Component: TorBrowserButton Version: Torbutton: 1.2.5
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points: 3
Reviewer: Sponsor:


I think!!! i found a way to detect mikeperry's TORBUTTON with javascript!!!!


Child Tickets

Attachments (1)

bug2339-demo.html (4.6 KB) - added by rransom 10 years ago.
demo page, downloaded 2010-12-30T14:09-08:00

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by bee

This is the DEMO page!!!!!!!!!!!!

Tell me if it works for real!!!!!!!!!!


comment:2 Changed 10 years ago by rransom

Summary: Detecting TORButton!!Torbutton Date hook parses dates incorrectly
Type: enhancementdefect

Changed 10 years ago by rransom

Attachment: bug2339-demo.html added

demo page, downloaded 2010-12-30T14:09-08:00

comment:3 Changed 10 years ago by bee

Hi rransom!!!!!!!!!!!!!

Tell me!!!!!!! It works for me!!!!! Does it work for real?!!!!!!!! or is it only a coincidence with the time zones?!!!!!!!!!!!!!!! does it work for you!!!!!?


comment:4 Changed 9 years ago by mikeperry

Component: TorbuttonTorBrowserButton
Priority: normalmajor

comment:5 in reply to:  4 Changed 9 years ago by bee

Component: TorBrowserButtonTorbutton
Priority: majornormal
Type: defectenhancement

Replying to mikeperry:
Hi mikeperry!!!!!!!!!!!!!!!!!!!!!
Well, if this was for real a major flaw!!! why waiting four months for the first response!!!!!!!!
Anyway!!!!!!!!!!!! i've now convinced myself!! that this flaw is only due to a coincidence with the timezones!!!!!!!! YEAH!!! I was unsure about this, but now i'm more sure!!!!!!!! so, it's true that the TOR BUTTON even when disabled keeps the "hooks" enabled!!!! Yeah!!!!!! it's not possible to disable the whole TorButton for real toggling it!!!!!!! because it keeps faking the dates & times even when disabled!!!! but apart for this strange thing, i don't feel like there is a real flaw anymore!!!!!!!!!!!!!!!!!!!!!!
BUT!!! i've the solution for you!!!!!!!!!!!!!!! I'm quite sure you won't listen to me, because you're too jealous of my super very good ideas!!!!!! JEALOUS!!!!!!! However, for the record!! so that you cannot say i didn't told this to you!!!!!! Instead of switching off TorButton!!!!!! You should create a new addon!!!!!!! The current TorButton addon, should only keep the logic to block everything!!! yeah, it's the defensive logic!!!!!!!!! And the new addon should display in the status bar the text "TorButton enabled"/"Disabled"!!!! So that when you toggle the button, the new addon should simulate the user's click on "Tools->Addons->Torbutton->disable" and then restarts firefox!!!!!!!!!! the same thing should be done when you enable tor button!!!!!!!!!
In this way, you can let "Firefox" to disable for real and for sure the addon for you!!!!!!!!! Also, the user will notice for sure when torbutton is changing status (on/off!!!!)!! because the browser will be restarted!!! (or shutdown!!!!!!!!!!!)
YEAH!!!!!!!!!!!!!!!!!!!! I think that you've to make TorButton more simple!!! this is smart!!! and use another addon to turn TorButton on or off!!!!!!! Firefox will then disable the DATE HOOKS automatically and in the right way!!!!!!!!!!!! and, when Firefox reboots, you can change other options like forcing or disabling the Private Browsing mode!!!!! and so on!!!!!!!!!
Using a new helper addon is a good idea!!! let it disable TorButton for you!!!!!!!! because i think that manually reversing the HOOK(s) when you switch TorButton is much more difficult!!!!!!!! and maybe this is why the current TorButton doesn't restore the right(original) timezone and date/time functions when it's turned off!!!!!!!!!!!!!!!!!!! so, as you're unable to write the right code!!!! but i'm very sure you can follow my super very good instructions!!! i suggest you to do what i told you!!!!!!!!!!!!!!!!! YEAH!!!!!!!!!!!!!


comment:6 Changed 9 years ago by mikeperry

Component: TorbuttonTorBrowserButton

comment:7 Changed 9 years ago by mikeperry

Milestone: TorBrowserBundle 2.2.x-stable

comment:8 Changed 9 years ago by mikeperry

Points: 3

comment:9 Changed 7 years ago by mikeperry

Resolution: fixed
Status: newclosed

Date hooks are gone.

Note: See TracTickets for help on using tickets.