Opened 3 years ago

Last modified 2 years ago

#23423 new defect

Remove redundant calls to connection_or_digest_is_known_relay()

Reported by: nickm Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Minor Keywords: refactor, redundant, technical-debt
Cc: Actual Points:
Parent ID: Points: 2
Reviewer: Sponsor:


Many calls to this function occur along with, and are redundant with, channel_is_client().

Child Tickets

#24904closeddgouletMake geoip use channel_is_client so it ignores flapping relaysCore Tor/Tor
#24905needs_revisionRemove redundant connection_or_digest_is_known_relay() from CHANNEL_IS_CLIENTCore Tor/Tor
#24906needs_revisionMake channelpadding_update_padding_for_channel() use !channel_is_client()Core Tor/Tor
#24907needs_revisionStop ignoring should_refuse_unknown_exits() for unauthenticated channelsCore Tor/Tor
#24910closedarmaMake rep_hist_note_circuit_handshake_* use channel_is_client()Core Tor/Tor
#24911needs_revisionRemove the known digest check from channel_check_for_duplicates()Core Tor/Tor

Change History (2)

comment:1 Changed 3 years ago by nickm

See #21585 for some background

comment:2 Changed 2 years ago by teor

We should also add comments to both functions saying when to use them.

Note: See TracTickets for help on using tickets.