Opened 2 years ago

Closed 2 years ago

#23425 closed defect (fixed)

Build fails when running without a terminal

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201709R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The Tor Browser build is failing with the following error when running without a terminal (such as in a cron job):

failed to set the terminal from the stdin: inappropriate ioctl for device

I think the reason is that in projects/common/runc-config.json, we have process.terminal set to true. We should set it to false when we are doing a build, but change it to true when we open a debugging shell.

Child Tickets

Change History (2)

comment:1 Changed 2 years ago by boklm

Keywords: TorBrowserTeam201709R added; TorBrowserTeam201709 removed
Status: assignedneeds_review

Branch bug_23425_v2 has a patch to fix that:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_23425_v2

I did a full rebuild using this patch to check that it didn't break the build.

comment:2 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good, merged to master (commit e21581e108a44915c0bd0f2acd346b02288a52a0).

Note: See TracTickets for help on using tickets.