Opened 6 weeks ago

Closed 5 weeks ago

#23426 closed defect (implemented)

Remove AllowDotExit

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: review-group-23
Cc: Actual Points: 0
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

This option has been deprecated since 0.2.9.x. We can remove it.

Child Tickets

Change History (8)

comment:1 Changed 6 weeks ago by nickm

Actual Points: 0
Status: assignedneeds_review

See branch remove_allow_dotexit.

comment:2 Changed 6 weeks ago by nickm

Keywords: review-group-23 added

Put 0.3.2 needs_review and merge_ready tickets into review-group-23.

comment:3 Changed 6 weeks ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewneeds_revision
+       * Probably this should be possible, since AllowDotExit no longer
+       * exists. */

You might mean "this should not be possible" ? Else that unreached assert is no good.

comment:4 Changed 6 weeks ago by nickm

Status: needs_revisionneeds_review

Pushed a fixup commit; better?

comment:5 Changed 6 weeks ago by dgoulet

Status: needs_reviewmerge_ready

lgtm;

comment:6 Changed 6 weeks ago by cypherpunks

I use AllowDotExit.

comment:7 Changed 6 weeks ago by nickm

I use AllowDotExit.

How, and why?

And what should we have done differently, so that you would have seen the deprecation warning some time between 0.2.9.x and now?

comment:8 Changed 5 weeks ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merging to master. We can revert f02fd6c3af71141241137403d070d72310cbfd82 if there turns out to be a great reason to have this.

Note: See TracTickets for help on using tickets.