Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#23436 closed task (fixed)

Error building firefox for Windows 64 in js/src/vm/TraceLogging.cpp

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201709R
Cc: tbb-team Actual Points:
Parent ID: #23229 Points:
Reviewer: Sponsor:

Description

We are getting the following error when trying to build firefox for Windows 64:

/var/tmp/dist/mingw-w64/helpers/x86_64-w64-mingw32-g++ -std=gnu++11 -mwindows -o TraceLogging.o -c   -DNDEBUG=1 -DTRIMMED=1 -D_CRT_RAND_S -DENABLE_SHARED_ARRAY_BUFFER -DEXPORT_JS_API -DJS_HAS_CTYPES '-DDLL_PREFIX=""' '-DDLL_SUFFIX=".dll"' -DFFI_BUILDING -DMOZ_HAS_MOZGLUE -I/var/tmp/build/firefox-89417fed09e5/js/src -I/var/tmp/build/firefox-89417fed09e5/obj-mingw/js/src -I/var/tmp/build/firefox-89417fed09e5/obj-mingw/js/src/ctypes/libffi/include -I/var/tmp/build/firefox-89417fed09e5/js/src/ctypes/libffi/src/x86 -I/var/tmp/build/firefox-89417fed09e5/obj-mingw/dist/include  -I/var/tmp/build/firefox-89417fed09e5/obj-mingw/dist/include/nspr          -DMOZILLA_CLIENT -include /var/tmp/build/firefox-89417fed09e5/obj-mingw/js/src/js-confdefs.h -MD -MP -MF .deps/TraceLogging.o.pp  -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++14-compat -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-format -fno-lifetime-dse -mms-bitfields -fno-rtti -fno-exceptions -fno-math-errno -pipe  -g -O -fomit-frame-pointer  -Wno-shadow -Werror=format  /var/tmp/build/firefox-89417fed09e5/js/src/vm/TraceLogging.cpp
/var/tmp/build/firefox-89417fed09e5/js/src/vm/TraceLogging.cpp: In member function 'js::TraceLoggerEventPayload* js::TraceLoggerThread::getOrCreateEventPayload(TraceLoggerTextId, const char*, size_t, size_t, const void*)':
/var/tmp/build/firefox-89417fed09e5/js/src/vm/TraceLogging.cpp:461:93: error: format '%u' expects argument of type 'unsigned int', but argument 5 has type 'size_t {aka long long unsigned int}' [-Werror=format=]
         snprintf(str, len + 1, "script %s:%" PRIuSIZE ":%" PRIuSIZE, filename, lineno, colno);
                                                                                             ^
/var/tmp/build/firefox-89417fed09e5/js/src/vm/TraceLogging.cpp:461:93: error: format '%u' expects argument of type 'unsigned int', but argument 6 has type 'size_t {aka long long unsigned int}' [-Werror=format=]
cc1plus: some warnings being treated as errors
make[5]: *** [TraceLogging.o] Error 1

Child Tickets

Change History (3)

comment:1 Changed 20 months ago by boklm

Keywords: TorBrowserTeam201709R added; TorBrowserTeam201709 removed
Status: newneeds_review

This build issue is fixed when using this patch: https://hg.mozilla.org/mozilla-central/rev/6909c7487def

comment:2 Changed 20 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Cherry-picked to tor-browser-52.3.0esr-7.5-2 (commit 7169757638781da3a706c7700bcd4eb2bc613591), thanks.

comment:3 Changed 20 months ago by cypherpunks

Decision making process at Mozilla, huh https://bugzilla.mozilla.org/show_bug.cgi?id=1114724#c11

Note: See TracTickets for help on using tickets.