Opened 2 years ago

Closed 2 years ago

#23456 closed task (fixed)

Build go and go pluggable transports for Windows 64

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201711R
Cc: tbb-team, dcf Actual Points:
Parent ID: #20636 Points:
Reviewer: Sponsor:

Description

We need to build go, and go pluggable transports (meek and obfs4) for Windows 64.

Child Tickets

Change History (10)

comment:1 Changed 2 years ago by boklm

This patch is fixing the build of go for Windows 64:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_20636_v6&id=bdd72adb05bdec2d5d05f2bff3cb3d6899f1e9be

Using this patch I am able to build meek and obfs4 for Windows 64.

I am not setting this ticket as needs_review yet as we probably want to finish #23228 first before merging this one.

comment:2 Changed 2 years ago by cypherpunks

(Could you also add GO386=387 to fix 32-bit builds?)

comment:3 in reply to:  2 Changed 2 years ago by boklm

Replying to cypherpunks:

(Could you also add GO386=387 to fix 32-bit builds?)

Do you have more details about the problem it should fix?

If I understand the documentation from https://golang.org/doc/install/source correctly, this option is either sse2 or 387 for non-sse2 support. However we don't support not SSE2 capable Windows machines anymore. Or do you want that for Linux builds?

comment:4 Changed 2 years ago by cypherpunks

For both. For consistency and determinism.

comment:5 Changed 2 years ago by yawning

For what it's worth, I do not support non-SSE2 obfs4proxy so if there are weird bugs, I will point and laugh at you.

comment:6 in reply to:  5 Changed 2 years ago by cypherpunks

Replying to yawning:

For what it's worth, I do not support non-SSE2 obfs4proxy so if there are weird bugs, I will point and laugh at you.

It worked a year or so ago, thus if you added weird bugs after that, "I will point and laugh at you."

comment:7 Changed 2 years ago by dcf

Cc: dcf added

comment:8 Changed 2 years ago by gk

Keywords: TorBrowserTeam201710 added; TorBrowserTeam201709 removed

Items for October 2017

comment:9 Changed 2 years ago by boklm

Keywords: TorBrowserTeam201711R added; TorBrowserTeam201710 removed
Status: assignedneeds_review

The branch bug_23456 in my git repo has a patch for review:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_23456&id=83407b9eee94991a7c8c13dbcaf35693f0e7c9e9

(this branch also contains the patch for #10026, so it should be cherry-picked if merged before #10026)

comment:10 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. This is commit 83407b9eee94991a7c8c13dbcaf35693f0e7c9e9 on master now.

Note: See TracTickets for help on using tickets.