#23467 closed defect (fixed)

running parameter vs. field mismatch

Reported by: cypherpunks Owned by: metrics-team
Priority: Medium Milestone: Onionoo-1.6.0
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

https://lists.torproject.org/pipermail/metrics-team/2017-September/000456.html

It might be that we're using two different definitions for "running":

 - The "running=false" parameter checks whether a bridge is contained in
the latest known status *and* has the "Running" flag assigned.

https://gitweb.torproject.org/onionoo.git/tree/src/main/java/org/torproject/onionoo/writer/SummaryDocumentWriter.java#n83

 - The "running" field in details documents only checks whether a bridge
is contained in the latest known status but ignores whether it got the
"Running" flag there or not.

https://gitweb.torproject.org/onionoo.git/tree/src/main/java/org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java#n866

We should probably use the first definition and also require the
"Running" flag before calling a bridge "running".

Child Tickets

Change History (3)

comment:1 Changed 15 months ago by karsten

Status: newneeds_review

Please review this tiny commit in my task-23467 branch. Tested locally, but needs review by another set of eyes.

comment:2 Changed 15 months ago by iwakeh

Status: needs_reviewmerge_ready

Looks ok. (Is the spelling of "Running" guaranteed by the protocol?)

comment:3 Changed 15 months ago by karsten

Milestone: Onionoo-1.6.0
Resolution: fixed
Status: merge_readyclosed

Merged, will be deployed as soon as the next release comes out! And yes, "Running" is the spelling that is specified in dir-spec.txt, so we can take that spelling as guaranteed. Closing. Thanks!

Note: See TracTickets for help on using tickets.