Opened 6 weeks ago

Last modified 5 weeks ago

#23470 merge_ready defect

Avoid relays resolving their own address on every download status check

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version: Tor: 0.2.8.1-alpha
Severity: Normal Keywords: 031-backport, 030-backport, 029-backport, 028-backport-maybe-not
Cc: Actual Points: 0.2
Parent ID: #21789 Points: 0.2
Reviewer: Sponsor:

Description

My branch 21789-mitigate has a fix that avoids relays doing useless resolves every time they check a download status. (And clients never do those resolves, because they're clients.)

Child Tickets

Change History (6)

comment:1 Changed 6 weeks ago by teor

Status: newneeds_review

comment:2 Changed 6 weeks ago by nickm

Status: needs_reviewmerge_ready

This looks fine to me. Should we consider backporting this?

comment:3 Changed 6 weeks ago by teor

Status: merge_readyneeds_revision

It needs a minor fix to the changes file and commit message to add this bug number, because trac was down.

comment:4 Changed 6 weeks ago by teor

Status: needs_revisionmerge_ready

See my branch bug23470, it has the same code, but the commit message and changes file use this bug number.

comment:5 Changed 6 weeks ago by teor

Keywords: 031-backport 030-backport 029-backport 028-backport-maybe-not added

And now bug23470-029.

comment:6 Changed 5 weeks ago by nickm

Milestone: Tor: 0.3.2.x-finalTor: 0.3.1.x-final

Trying this in master, marking for possible backport.

Note: See TracTickets for help on using tickets.