#23479 closed defect (fixed)

Bug: ../src/or/config.c:785: get_options_mutable: Non-fatal assertion ! in_option_validation failed

Reported by: gk Owned by: nickm
Priority: High Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-config, tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Updating my local tor master branch and using it in my Tor Browser (Linux 64-bit) gives me:

Sep 12 14:06:23.000 [notice] New control connection opened from 127.0.0.1.
Sep 12 14:06:23.000 [warn] tor_bug_occurred_(): Bug: ../src/or/config.c:785: get_options_mutable: Non-fatal assertion ! in_option_validation failed. (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug: Non-fatal assertion ! in_option_validation failed in get_options_mutable at ../src/or/config.c:785. Stack trace: (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /usr/lib/x86_64-linux-gnu/libasan.so.4(+0x53621) [0x7f823aa46621] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /home/thomas/tor-browser_en-US/Browser/TorBrowser/Tor/tor(log_backtrace+0x45) [0x55c9b5cb2c15] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /home/thomas/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_bug_occurred_+0x12c) [0x55c9b5d117fc] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /home/thomas/tor-browser_en-US/Browser/TorBrowser/Tor/tor(get_options_mutable+0x92) [0x55c9b5abfd12] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /home/thomas/tor-browser_en-US/Browser/TorBrowser/Tor/tor(options_trial_assign+0xa6) [0x55c9b5aea376] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /home/thomas/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x962b1c) [0x55c9b5b6db1c] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /home/thomas/tor-browser_en-US/Browser/TorBrowser/Tor/tor(connection_control_process_inbuf+0x247d) [0x55c9b5b796fd] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /home/thomas/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x912f1d) [0x55c9b5b1df1d] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /home/thomas/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x689a58) [0x55c9b5894a58] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /usr/lib/x86_64-linux-gnu/libevent-2.1.so.6(+0x229ba) [0x7f823a2a19ba] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /usr/lib/x86_64-linux-gnu/libevent-2.1.so.6(event_base_loop+0x5a7) [0x7f823a2a2537] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /home/thomas/tor-browser_en-US/Browser/TorBrowser/Tor/tor(do_main_loop+0x410) [0x55c9b5896670] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /home/thomas/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_main+0x143d) [0x55c9b589c08d] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /home/thomas/tor-browser_en-US/Browser/TorBrowser/Tor/tor(main+0x1c) [0x55c9b588793c] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1) [0x7f82384842e1] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)
Sep 12 14:06:23.000 [warn] Bug:     /home/thomas/tor-browser_en-US/Browser/TorBrowser/Tor/tor(_start+0x2a) [0x55c9b588a2aa] (on Tor 0.3.2.0-alpha-dev 6e4967ef03fb5d04)

This should have been introduced fairly recently (like in the last couple of days) as I am following tor master pretty closely.

Child Tickets

Change History (11)

comment:1 Changed 15 months ago by gk

Milestone: Tor: 0.3.2.x-final

comment:2 Changed 15 months ago by dgoulet

Keywords: tor-config tor-client added
Priority: MediumHigh

Oooook #22281 was merged yesterday but then I just realized this that in options_trial_assign():

  in_option_validation = 1;

  if (options_validate(get_options_mutable(), trial_options,
                       global_default_options, 1, msg) < 0) {

Basically, setting in_option_validation to 1 and then right after calling get_options_mutable() which triggers the assert...

Two things. 1) Why don't I get this while using master since yesterday... and 2) How come our unit tests didn't catch that... ?

comment:3 Changed 15 months ago by nickm

bug23479 has the fix. You didn't see this if you weren't calling setoption. And probably the unit tests don't have enough coverage of controller stuff. This should have shown up in the stem tests, though.

comment:4 Changed 15 months ago by dgoulet

Status: newmerge_ready

ack.

comment:5 Changed 15 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged!

comment:6 Changed 14 months ago by toralf

appeared today at Tor exit relay running at a stable hardened Gentoo linux server with Tor 0.3.2.2-alpha :

Oct 09 07:02:59.000 [notice] Received reload signal (hup). Reloading config and resetting internal state.
Oct 09 07:02:59.000 [notice] Read configuration file "/etc/tor/torrc2".
Oct 09 07:02:59.000 [warn] tor_bug_occurred_(): Bug: src/or/config.c:807: get_options_mutable: Non-fatal assertion ! in_option_validation failed. (on Tor 0.3.2.2-alpha e2a2704f17415d8a)
Oct 09 07:02:59.000 [warn] Bug:     /usr/bin/tor(log_backtrace+0x51) [0x5585bfac7e51] (on Tor 0.3.2.2-alpha e2a2704f17415d8a)
Oct 09 07:02:59.000 [warn] Bug:     /usr/bin/tor(tor_bug_occurred_+0xc5) [0x5585bfae4985] (on Tor 0.3.2.2-alpha e2a2704f17415d8a)
Oct 09 07:02:59.000 [warn] Bug:     /usr/bin/tor(get_options_mutable+0x9a) [0x5585bfa31a5a] (on Tor 0.3.2.2-alpha e2a2704f17415d8a)
Oct 09 07:02:59.000 [warn] Bug:     /usr/bin/tor(onion_skin_TAP_server_handshake+0x205) [0x5585bf9a3535] (on Tor 0.3.2.2-alpha e2a2704f17415d8a)
Oct 09 07:02:59.000 [warn] Bug:     /usr/bin/tor(onion_skin_server_handshake+0xd2) [0x5585bf9a1922] (on Tor 0.3.2.2-alpha e2a2704f17415d8a)
Oct 09 07:02:59.000 [warn] Bug:     /usr/bin/tor(+0x12e824) [0x5585bfa6b824] (on Tor 0.3.2.2-alpha e2a2704f17415d8a)
Oct 09 07:02:59.000 [warn] Bug:     /usr/bin/tor(+0x1ae2c1) [0x5585bfaeb2c1] (on Tor 0.3.2.2-alpha e2a2704f17415d8a)
Oct 09 07:02:59.000 [warn] Bug:     /usr/bin/tor(+0x1aec78) [0x5585bfaebc78] (on Tor 0.3.2.2-alpha e2a2704f17415d8a)
Oct 09 07:02:59.000 [warn] Bug:     /lib64/libpthread.so.0(+0x7270) [0x7f0612119270] (on Tor 0.3.2.2-alpha e2a2704f17415d8a)
Oct 09 07:02:59.000 [warn] Bug:     /lib64/libc.so.6(clone+0x6d) [0x7f0611e5cf0d] (on Tor 0.3.2.2-alpha e2a2704f17415d8a)
Last edited 14 months ago by toralf (previous) (diff)

comment:7 Changed 14 months ago by toralf

Resolution: fixed
Status: closedreopened

comment:8 Changed 14 months ago by nickm

Wow, that's bizarre. What's calling get_options() [or its kin] from onion_skin_TAP_server_handshake?

comment:9 Changed 14 months ago by nickm

Owner: set to nickm
Status: reopenedaccepted

comment:10 Changed 14 months ago by nickm

Oh, darnit. It's LOG_PROTOCOL_WARN.

comment:11 Changed 14 months ago by nickm

Resolution: fixed
Status: acceptedclosed

Opened #23952 to track the onion_skin_TAP_server_handshake issue.

Note: See TracTickets for help on using tickets.