#23480 closed defect (fixed)

hs: Rate limit some logs in hs-v3 subsystem

Reported by: dgoulet Owned by:
Priority: Low Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, prop224
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When bootstrapping or downloading new directory data, those log statements can basically be printed for each relay in the consensus:

[info] hs_service_dir_info_changed(): New dirinfo arrived: consider reuploading descriptor
[info] node_set_hsdir_index(): Not setting hsdir index with a non-live consensus.

Child Tickets

Change History (4)

comment:1 Changed 13 months ago by dgoulet

I would also fix a logging statement in hs_cache.c in the process with this ticket.

       char key_b64[BASE64_DIGEST256_LEN + 1];
       base64_encode(key_b64, sizeof(key_b64), (const char *) key,
                     DIGEST256_LEN, 0);
       log_info(LD_REND, "Removing v3 descriptor '%s' from HSDir cache",
                safe_str_client(key_b64));

... which prints garbage as the base64 value. We should use digest256_to_base64() here and I confirm it works.

comment:2 Changed 13 months ago by dgoulet

Reviewer: dgoulet
Status: assignedneeds_review

See branch: ticket23480_032_01

comment:3 Changed 13 months ago by nickm

looks fine; merging!

comment:4 Changed 13 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.