Opened 2 years ago

Last modified 13 months ago

#23501 assigned defect

Refactor rep_hist_format_hs_stats() to add noise when counters are initialised

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.2.14-alpha
Severity: Normal Keywords: tor-relay, privcount, refactor, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: #25263 Points: 0.5
Reviewer: Sponsor: SponsorQ-can

Description

This makes the code shorter, and the security guarantees easier to reason about (it's how experimental privcount does it).

See #23414 for background.

Child Tickets

Change History (8)

comment:1 Changed 2 years ago by nickm

Sponsor: SponsorQ-can

comment:2 Changed 2 years ago by teor

We should revise or close these tickets based on Appendix C in the latest privcount-shamir spec:

https://github.com/teor2345/privcount_shamir/blob/noise-limits/doc/xxx-privcount-with-shamir.txt

The good news is that we probably don't need to care about extreme values or binning, because properly implemented noise has known limits, and doesn't need binning.

comment:3 Changed 21 months ago by dgoulet

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

Moving a bunch of tickets from 033 to 034.

comment:4 Changed 20 months ago by teor

Parent ID: #23061#25263

comment:5 Changed 19 months ago by nickm

Keywords: 034-triage-20180328 added

comment:6 Changed 19 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:7 Changed 19 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

comment:8 Changed 13 months ago by teor

Status: newassigned

We should fix these issues by migrating these statistics to PrivCount in Tor.
See #25263 and its parents for details.

Note: See TracTickets for help on using tickets.