Opened 2 years ago

Closed 2 years ago

#23513 closed defect (fixed)

When there is an error while starting a container, we don't clean up the container files

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201709R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When there is an error starting a container (for instance due to #23039), we exit with many lines of errors such as:

cannot unlink file for /home/user/tor-browser-build/tmp/rbm-ZSCgVC/rbm-containers/5974d3088083038cf834dd21ae48552798cf288bc8949e376e617583dc8c2886/rootfs/lib/x86_64-linux-gnu/libnss_files.so.2: Permission denied at /usr/share/perl5/vendor_perl/File/Temp.pm line 1616.
cannot restore permissions to 0120777 for /home/user/tor-browser-build/tmp/rbm-ZSCgVC/rbm-containers/5974d3088083038cf834dd21ae48552798cf288bc8949e376e617583dc8c2886/rootfs/lib/x86_64-linux-gnu/libnss_files.so.2: Permission denied at /usr/share/perl5/vendor_perl/File/Temp.pm line 1616.
cannot unlink file for /home/user/tor-browser-build/tmp/rbm-ZSCgVC/rbm-containers/5974d3088083038cf834dd21ae48552798cf288bc8949e376e617583dc8c2886/rootfs/lib/x86_64-linux-gnu/libncursesw.so.5: Permission denied at /usr/share/perl5/vendor_perl/File/Temp.pm line 1616.

And the files from the container are not removed.

Child Tickets

Attachments (1)

0001-Bug-23513-run-remote_finish-when-there-was-an-error-.patch (1.1 KB) - added by boklm 2 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 2 years ago by boklm

Keywords: TorBrowserTeam201709R added; TorBrowserTeam201709 removed
Status: assignedneeds_review

I attached a patch for rbm.git fixing this issue.

comment:2 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. This is commit 78d9b11aead5ba9b2386f7ebb2003772823fa293 on master (rbm) and I pushed an update to tor-browser-build as well (commit 90653b4d43d04c8394df3c194d5469aee8980510).

Note: See TracTickets for help on using tickets.