Opened 2 months ago

Last modified 42 hours ago

#23518 accepted enhancement

Turn Atlas into page on Tor Metrics

Reported by: karsten Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Atlas Version:
Severity: Normal Keywords: metrics-2017
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by irl)

We briefly discussed this before, but I didn't find a ticket for it, so I made this one.

Let's consider turning Atlas into a page on Tor Metrics. It could live under "Home >> Services >> Atlas".

From a technical perspective I think we could add Atlas as Git submodule and copy its index.html into a JSP, so that we can include the Tor Metrics banner and footer. And we'd copy over all required JS files.

It would certainly help to get rid of Atlas' navbar and footer and make sure that it works well with Metrics' style file.

Child Tickets

TicketTypeStatusOwnerSummary
#12522enhancementassignedmetrics-teamAdd sitemap.xml to Globe to make details pages indexed by Google et al.
#23782enhancementacceptedirlExpose all possible query features in an "Advanced Search" HTML form

Change History (13)

comment:1 Changed 2 months ago by irl

karsten: I'm going to need to have some idea of how to set up a dev environment for this. Will things just work if I tell Eclipse to do Tomcat things with metrics-web?

comment:2 Changed 2 months ago by karsten

irl: It's complicated! :) I'd say don't worry about the technical integration part. Better import Metrics' CSS file into Atlas and make sure the page looks okay there (though without banner and footer). I'll happily do the rest.

comment:3 Changed 8 weeks ago by karsten

Keywords: metrics-2018 added

comment:4 Changed 8 weeks ago by karsten

Keywords: metrics-2017 added; metrics-2018 removed

comment:5 Changed 10 days ago by irl

Status: newassigned

Moving this into my queue.

comment:6 Changed 9 days ago by irl

Description: modified (diff)
Status: assignedaccepted

I've now merged the metrics theme with Atlas and rebranded it as Relay Search. For now we can display a message at the top of the page to explain to users about the rebranding. This will be merged and continue to be served by the static mirrors for now, waiting for embedded Jetty in metrics-web before merging into the metrics-web codebase.

Javascript libraries have been updated for compatibility with the versions used by metrics-web, including jQuery and bootstrap.

The only issue that has been found with compatibility is the "return to top" button used on the website which uses a URL fragment, conflicting with the URL routing for the javascript application.

Many resources are now loaded from metrics.torproject.org instead of being local to the Atlas codebase, which is something we should be aware of but is not a large problem as that's where we'll want them to be loaded from in the future anyway.

Currently services.html has:

<li><a href="https://atlas.torproject.org/" target="_blank">Atlas</a> displays data about single relays and bridges in the Tor network.</li>

Let's change this to:

<li><a href="https://atlas.torproject.org/">Relay Search</a> displays data about single relays and bridges in the Tor Network.</li>

(The omission of the _blank target is deliberate, as Relay Search now matches the Metrics branding this should be seamless for users.)

comment:7 in reply to:  6 Changed 9 days ago by karsten

Replying to irl:

Currently services.html has:

<li><a href="https://atlas.torproject.org/" target="_blank">Atlas</a> displays data about single relays and bridges in the Tor network.</li>

Let's change this to:

<li><a href="https://atlas.torproject.org/">Relay Search</a> displays data about single relays and bridges in the Tor Network.</li>

(The omission of the _blank target is deliberate, as Relay Search now matches the Metrics branding this should be seamless for users.)

Changed, merged, and deployed!

Thanks for making all the changes on the Atlas/Relay Search side!

comment:8 Changed 9 days ago by irl

Thanks. (:

comment:9 Changed 5 days ago by atagar

Hi Karsten, hi irl. I'm a bit curious: what is the long term plan around this? Do you plan to rewrite Atlas or keep it as a frame?

comment:10 Changed 4 days ago by irl

The index.html will become a JSP, and the JavaScript application will be loaded as it currently is, just with the codebase merged into the metrics-web codebase.

Later there is a possibility that portions will be rewritten in Java, but this will depend on a Java Onionoo client (metrics-bot kind of has one, but it's not anywhere near complete).

comment:11 Changed 2 days ago by teor

Is there any chance of getting the search box back on every Relay Search page?
It was really useful on Atlas.

comment:12 Changed 2 days ago by irl

teor: See #24274

comment:13 Changed 42 hours ago by irl

We should dynamically generate the fallback_dir.js script from tor's source code in order to have it automatically kept up to date. Alternatively, this could be added to Onionoo.

If metrics-lib does not already have a parser for this file format, it would probably also be a good idea to add one.

Note: See TracTickets for help on using tickets.