Opened 17 months ago
Closed 15 months ago
#23522 closed defect (fixed)
Improve tooltip on DNS name field (and maybe title)
Reported by: | irl | Owned by: | irl |
---|---|---|---|
Priority: | Medium | Milestone: | |
Component: | Metrics/Relay Search | Version: | |
Severity: | Normal | Keywords: | metrics-2017 |
Cc: | karsten | Actual Points: | |
Parent ID: | Points: | ||
Reviewer: | Sponsor: |
Description
#18342 has a discussion on the semantics of the host_name field.
Child Tickets
Change History (9)
comment:1 Changed 17 months ago by
Summary: | tooltip on dns name field (and maybe title) could need improvement → Improve tooltip on DNS name field (and maybe title) |
---|
comment:2 Changed 17 months ago by
Keywords: | metrics-2018 added |
---|
comment:3 Changed 17 months ago by
Keywords: | metrics-2017 added; metrics-2018 removed |
---|
comment:5 Changed 15 months ago by
Status: | assigned → accepted |
---|
comment:6 Changed 15 months ago by
Cc: | karsten added |
---|---|
Status: | accepted → needs_review |
- <dt><span class="tip" title="The DNS name for the relay as found by performing a reverse lookup on its first IP address.">DNS Name</span></dt> + <dt><span class="tip" title="Host name as found in a reverse DNS lookup of the relay's first IP address. This field is updated at most once in 12 hours, unless the relay IP add ress changes. Omitted if the relay IP address was not looked up, if no lookup request was successful yet or if no A record was found matching the PTR record.">DNS Name</span></dt>
karsten: Does this look more accurate?
comment:7 Changed 15 months ago by
Pretty much. Some trivial comments:
- I'd write "primary IP address" instead of "first IP address" to indicate that it's not just the first that happens to be listed, but the one that the relay uses to register at the directory authorities.
- arma would probably complain to me about not using the Oxford comma.
- You know that last case with A and PTR records far better than I, so I trust you that it's a good addition. I guess we should also extend the Onionoo's host_name field specification to cover that case. Does that make sense?
comment:8 Changed 15 months ago by
Status: | needs_review → needs_revision |
---|
I should go and read the code to be sure. This was mostly based on the discussion in #18342.
comment:9 Changed 15 months ago by
Resolution: | → fixed |
---|---|
Status: | needs_revision → closed |
Ok, I read the Java documentation. It didn't help. Then I looked at StackOverflow.
My description is correct.
Fixed in ce07ca3b784f9b76def9387790731268a5ee4750.
Note: See
TracTickets for help on using
tickets.
Tweak summary.