Opened 3 years ago

Closed 3 years ago

#23533 closed defect (fixed)

Repair bug in geoip/rephist reporting from relays that only download microdescriptors.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 031-backport 030-backport
Cc: karsten Actual Points:
Parent ID: Points:
Reviewer: catalyst Sponsor:


Child Tickets

Change History (5)

comment:1 Changed 3 years ago by nickm

Keywords: 031-backport 030-backport added
Milestone: Tor: 0.3.2.x-final
Owner: set to nickm
Status: newaccepted

bug23533_031 fixes this. It's a bug on 0.3.0, I believe, so we might consider backporting even further (though it will require code changes). We should see whether this has been causing trouble with metrics at all.

comment:2 Changed 3 years ago by nickm

Status: acceptedneeds_review

comment:3 Changed 3 years ago by catalyst

Reviewer: catalyst
Status: needs_reviewmerge_ready

Looks good to me. On master, there's a merge conflict with the #23532 patch which should be resolved carefully.

comment:4 Changed 3 years ago by nickm

Milestone: Tor: 0.3.2.x-finalTor: 0.3.0.x-final

merged to maint-0.3.1 and forward, with merge conflicts resolved as 639766dbc39c37d9864b99bd024faa5967b22c80.

Marking for possible backport to maint-0.3.0

comment:5 Changed 3 years ago by nickm

Milestone: Tor: 0.3.0.x-finalTor: 0.3.1.x-final
Resolution: fixed
Status: merge_readyclosed

Going for "no backport" since it's already in 0.3.1, 0.3.0 will be end-of-life in a couple months, and the bug is not present in 0.2.9.

Note: See TracTickets for help on using tickets.