Opened 13 months ago

Closed 11 months ago

Last modified 11 months ago

#23544 closed enhancement (fixed)

Add recommended_version parameter

Reported by: cypherpunks Owned by: metrics-team
Priority: Medium Milestone: Onionoo-1.8.0
Component: Metrics/Onionoo Version:
Severity: Normal Keywords: metrics-2017
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

With #21427 we got the version parameter which allows us to search for relays that use a version that also start with the given parameter.

A somewhat obvious use case is:

"Give me all relays with contact ... which run a version that is not recommended"

For this use-case we would need the recommended_version parameter that filters
entries based on the recommended_version boolean field.

Child Tickets

Change History (10)

comment:1 Changed 13 months ago by karsten

Sounds like a good idea to me and shouldn't be terribly hard to implement.

comment:2 Changed 13 months ago by karsten

Summary: add recommended_version parameterAdd recommended_version parameter

Capitalize summary.

comment:3 Changed 13 months ago by karsten

Keywords: metrics-2018 added

comment:4 Changed 13 months ago by karsten

Keywords: metrics-2017 added; metrics-2018 removed

comment:5 Changed 11 months ago by karsten

It was indeed not terribly hard to implement. My branch task-23544 contains an implementation that needs more review (than self review) and more testing.

But before we merge this, let's decide what to do with #23962. If we decide to include bridges in the "version" parameter, we should also include them in the "recommended_version" parameter. If we decide against it, we can move forward with this ticket by reviewing and merging my branch. But let's not do that if we later decide to change the "version" parameter, because then we'll have to do the same with the "recommended_version" parameter.

Not setting to needs_review yet.

comment:6 Changed 11 months ago by karsten

Suggested specification for the relays-only parameter:

"Return only relays running a Tor software version that is recommended (parameter value true) or not recommended by the directory authorities (parameter value false). Relays are not contained in either result, if the version they are running is not known. Bridges are not contained in the result, regardless of which Tor version they are running. Parameter values are case-insensitive."

comment:7 Changed 11 months ago by karsten

Status: newneeds_review

(I worked on all currently open (recommended) version related Onionoo tickets including this one: #22488, #23962, #21827, and #23544.)

After working on #23962 today I revised my branch above to also include bridges in the "recommended_version" parameter.

Please review the fourth commit 11e5bbd in my tasks-22488-23962-21827-23544 branch together with specification changes in commit 75c7626 in my corresponding metrics-web branch.

comment:8 Changed 11 months ago by iwakeh

Status: needs_reviewmerge_ready

Ready to go (cf. comments on #22488, #23962, #21827).

(The review of of commits based on each other in one branch distributed across several tickets, is a very cumbersome review situation. If commits are as tightly connected as they are here they shouldn't be distributed on different tickets. As soon as the connection becomes apparent the tasks should be merged. The redundancy also becomes visible in the very similar ready-for-review comments and replies.)

comment:9 in reply to:  8 Changed 11 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

Replying to iwakeh:

Ready to go (cf. comments on #22488, #23962, #21827).

Great, thanks for checking! Merged. Closing.

(The review of of commits based on each other in one branch distributed across several tickets, is a very cumbersome review situation. If commits are as tightly connected as they are here they shouldn't be distributed on different tickets. As soon as the connection becomes apparent the tasks should be merged. The redundancy also becomes visible in the very similar ready-for-review comments and replies.)

True. I guess next time we could merge the tickets first and then do the reviewing part there.

comment:10 Changed 11 months ago by iwakeh

Milestone: Onionoo-1.8.0

This will be part of the next release.

Note: See TracTickets for help on using tickets.