Opened 3 years ago

Closed 3 years ago

#23562 closed task (implemented)

keep changes files on master release-ready

Reported by: catalyst Owned by:
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ci tor-doc tor-releng
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Recently, running make check-changes produced dozens of errors on master. We should make sure master is check-changes clean so we can run make check-changes in our CI automation (and start doing so).

Child Tickets

#23563closednickmdocument changes files release-readiness requirement in doc/HACKINGCore Tor/Tor
#23564closednickmrun make check-changes in CICore Tor/Tor

Change History (3)

comment:1 Changed 3 years ago by nickm

To do this, we also need to make sure that the lintChanges script doesn't have any false positives.

comment:2 Changed 3 years ago by nickm

(But probably the best way to handle false positives here is to just merge a fix that runs check-changes as part of 'make check', and to fix the false positives as we encounter them.)

comment:3 Changed 3 years ago by nickm

Resolution: implemented
Status: newclosed

Going to close this, since its children are closed.

Note: See TracTickets for help on using tickets.