Opened 2 years ago

Closed 2 years ago

#23563 closed task (fixed)

document changes files release-readiness requirement in doc/HACKING

Reported by: catalyst Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-doc tor-releng
Cc: Actual Points:
Parent ID: #23562 Points:
Reviewer: Sponsor:

Description


Child Tickets

Change History (7)

comment:1 Changed 2 years ago by catalyst

Keywords: ci removed

comment:2 Changed 2 years ago by nickm

Status: newneeds_review

Somewhat improved in 2032d7ca6f0d08. Do you like this now? If so let's close this and its parent.

comment:3 Changed 2 years ago by catalyst

Status: needs_reviewneeds_revision

Mostly looks good; thanks! I would suggest adding a sentence or two in HowToReview.md and possibly also CodingStandards.md about trying to conform to the changes file writing style that release engineers will apply in II.1.2 of ReleasingTor.md. (That way we can hopefully get reviewers and patch authors to help take more text writing/editing load off of the release engineers.)

comment:4 Changed 2 years ago by nickm

Owner: set to nickm
Status: needs_revisionaccepted

setting owner

comment:5 Changed 2 years ago by nickm

Status: acceptedneeds_revision

comment:6 Changed 2 years ago by nickm

Status: needs_revisionneeds_review

Further improvements in cbea334d6ba564.

comment:7 Changed 2 years ago by catalyst

Resolution: fixed
Status: needs_reviewclosed

Looks good; thanks! We can keep an eye on how this works in practice in the next few releases and update accordingly.

Note: See TracTickets for help on using tickets.