Opened 9 months ago

Closed 8 months ago

#23571 closed defect (fixed)

Stop closing channels out from under OR connections in hibernate_go_dormant()

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version: Tor: 0.2.4.7-alpha
Severity: Normal Keywords: tor-relay, tor-client, hibernate, review-group-24
Cc: Actual Points: 0.2
Parent ID: Points: 0.2
Reviewer: Sponsor:

Description (last modified by teor)

This allows dormant connections to flush then close normally.
Bugfix on #7267 in 0.2.4.7-alpha.

Child Tickets

Change History (10)

comment:1 Changed 9 months ago by arma

Does the "this" and the ".2 points" mean you've got a patch?

comment:2 Changed 9 months ago by teor

Status: newneeds_review

Please see my branch bug7267, which uses the documented function for closing OR connections.

comment:3 Changed 9 months ago by teor

Description: modified (diff)
Owner: set to teor
Status: needs_reviewassigned

comment:4 Changed 9 months ago by teor

Status: assignedneeds_review

comment:5 Changed 8 months ago by nickm

Keywords: review-group-24 added

review-group-24 is now open.

comment:6 Changed 8 months ago by nickm

Do we want to be setting the hold_open_until_flushed flag here, really? I don't think we did that before...

comment:7 Changed 8 months ago by nickm

Status: needs_reviewneeds_revision

(Otherwise, looks plausible. I assume this is reasonably chutney-tested?)

comment:8 Changed 8 months ago by teor

Status: needs_revisionneeds_review

Yes, I've used this patch repeatedly in chutney, because it gives better behaviour when counting circuits in experimental privcount.

I added a fixup that sets the hold_open_until_flushed flag to 0.

comment:9 Changed 8 months ago by nickm

Status: needs_reviewmerge_ready

comment:10 Changed 8 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Squashed as bug23571_033_squashed and merged to master. Thanks!

Note: See TracTickets for help on using tickets.