Make service_intro_point_new() take a node instead of an extend_info
service_intro_point_new() and hs_desc_link_specifier_new() need to take a node_t, so they can fill it in with IPv4 and IPv6 addresses.
Activity
changed milestone to %Tor: 0.4.1.x-final
added 034-removed-20180328 034-triage-20180328 040-unreached-20190109 041-proposed actualpoints::2 component::core tor/tor fast-fix ipv6 milestone::Tor: 0.4.1.x-final owner::teor parent::23588 points::1 priority::medium prop224 resolution::fixed reviewer::dgoulet severity::normal single-onion status::closed tor-hs type::defect version::tor 0.3.2.1-alpha labels
In my commit b4aa8fc3d9 in my branch bug23820_032 (#23820 (moved)), I ripped out IPv6 support in these functions. We'll need to revert that commit, and then fix the issues in the function.
Remove buggy IPv6 support from pick_intro_point() and service_intro_point_new() The previous version of these functions had the following issues: * they can't supply both the IPv4 and IPv6 addresses in link specifiers, * they try to fall back to a 3-hop path when the address for a direct connection is unreachable, but this isn't supported by launch_rendezvous_point_circuit(), so it fails. But we can't fix these things in a bugfix release. Instead, always put IPv4 addresses in link specifiers. And if a v3 single onion service can't reach any intro points, fail.We can implement this ticket easily by replacing the link specifier part of service_intro_point_new() with get_lspecs_from_node().
This refactor completes part of #23759 (moved).
Trac:
Milestone: Tor: unspecified to Tor: 0.3.5.x-final
Version: N/A to Tor: 0.3.2.1-alpha
Owner: dgoulet to teorSee my branch bug23576 on https://github.com/teor2345/tor.git
This refactor also puts intro IPv6 link specifiers in onion service descriptors (#26992 (moved)).
It passes make check and make test-network-all on my machine, but will probably fail Appveyor CI due to #26986 (moved).
Trac:
Status: assigned to needs_reviewPull request is: https://github.com/torproject/tor/pull/254
This looks good and I like the code simplification!
I left a few nitpicks on the PR that you might want to handle.
Also, should we try to rebase this so that we can see the appveyor green checkmark (now that #26986 (moved) got fixed)?
Trac:
Status: needs_review to needs_revisionReplying to asn:
This looks good and I like the code simplification!
I left a few nitpicks on the PR that you might want to handle.
See the PR for my changes.
Also, should we try to rebase this so that we can see the appveyor green checkmark (now that #26986 (moved) got fixed)?
See my branch bug23576-rebased:
- https://github.com/teor2345/tor/tree/bug23576-rebased
- https://ci.appveyor.com/project/teor2345/tor/build/1.0.84
- https://travis-ci.org/teor2345/tor/builds/419564854
I'd like to defer the merge to early in 0.3.6, for the same reasons as: https://trac.torproject.org/projects/tor/ticket/23588#comment:52
We're still missing #23818 (moved), and when we test in #27251 (moved), we might find we're missing other things as well. I'd like to have a full release to implement and test them.
Trac:
Milestone: Tor: 0.3.5.x-final to Tor: 0.3.6.x-final
Status: needs_revision to needs_reviewI think this branch fails
make test-network-all:neel@megora:~/Code/Tor/back/teor2345-tor % make test-network-all mkdir -p ./test_network_log ping6 ::1 or ping ::1 succeeded, running IPv6 flavors: bridges+ipv6-min ipv6-exit-min hs-v23-ipv6-md single-onion-ipv6-md. tor-stable not found, skipping mixed flavors: mixed+hs-v23. SKIP: mixed+hs-v23 PASS: basic-min Detail: chutney/tools/warnings.sh /usr/home/neel/Code/Tor/chutney/net/nodes.1535248896 Warning: Rejected vote from 127.0.0.1 ("Duplicate discarded"). Number: 1 PASS: bridges-min PASS: hs-v2-min FAIL: hs-v3-min Detail: chutney/tools/warnings.sh /usr/home/neel/Code/Tor/chutney/net/nodes.1535249030 Warning: Rejected vote from 127.0.0.1 ("Duplicate discarded"). Number: 1 FAIL: single-onion-v23 PASS: bridges+ipv6-min PASS: ipv6-exit-min FAIL: hs-v23-ipv6-md PASS: single-onion-ipv6-md Log and result files are available in ./test_network_log. *** Error code 1 Stop. make: stopped in /usr/home/neel/Code/Tor/back/teor2345-tor neel@megora:~/Code/Tor/back/teor2345-torIs this branch failing because of missing code (that should get implemented), bugs in the code, or just my computer?
Trac:
Cc: N/A to neel@neelc.orgIt's possible that this code is buggy. Since it's supposed to be a refactor, there shouldn't be any missing code.
But we've also fixed some issues in tor and chutney over the last few days.
Please try again with:
- the latest version of chutney master, and
- bug23576-rebased merged into tor master
If it still fails, I'll take a look at it some time next week.
