Opened 10 months ago

Last modified 3 months ago

#23579 accepted enhancement

sched: Add accessors for channel_pending list

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: refactor, easy, tor-sched, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: #23993 Points:
Reviewer: Sponsor: SponsorV

Description

Let's make this list private and have accessors.

Child Tickets

Change History (10)

comment:1 Changed 9 months ago by dgoulet

Sponsor: SponsorV

Tagging all scheduler (and KIST) related tickets for SponsorV

comment:2 Changed 9 months ago by dgoulet

Owner: set to dgoulet
Status: newaccepted

Taking the scheduler related tickets.

comment:3 Changed 9 months ago by dgoulet

Parent ID: 23993

comment:4 Changed 9 months ago by dgoulet

Parent ID: 23993#23993

comment:5 Changed 8 months ago by asn

Can't find this channel_pending_list thing on latest master. Where is it? :)

comment:6 in reply to:  5 Changed 8 months ago by dgoulet

Replying to asn:

Can't find this channel_pending_list thing on latest master. Where is it? :)

hehe... it is STATIC smartlist_t *channels_pending = NULL; in scheduler.c :).

The different type of scheduler poke at it using get_channels_pending() which is not that ideal.

scheduler_kist.c and scheduler_vanilla.c are the one doing that.

comment:7 Changed 6 months ago by dgoulet

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

Move 033 ticket I own to 034

comment:8 Changed 4 months ago by nickm

Keywords: 034-triage-20180328 added

comment:9 Changed 4 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:10 Changed 3 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Note: See TracTickets for help on using tickets.