Increased crash rate due to disabled Windows DLL blocklist

Maybe, somebody (from Mozilla?) adapt it to mingw-w64. Mozilla has a test for it, and "a failure in this test is considered a release blocker."

added GeorgKoppen201709 TorBrowserTeam201709 component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-backported type::defect labels

What makes you believe the Windows DLL blocklist is disabled in Tor Browser?

Trac:
Status: new to needs_information

Obviously,

#if defined(_MSC_VER) && (defined(_M_IX86) || defined(_M_X64))
#define HAS_DLL_BLOCKLIST

Trac:
Status: needs_information to new

Replying to cypherpunks:

Obviously, {{{ #if defined(_MSC_VER) && (defined(_M_IX86) || defined(_M_X64)) #define HAS_DLL_BLOCKLIST }}}

Interesting but that's not something that's new. (Like included with the ESR 52 release). But we can test whether it works with mingw-w64 builds as well and ship it in that case.

Trac:
Keywords: N/A deleted, TorBrowserTeam201709, GeorgKoppen201709 added

Heh, it turns out tjr landed that one already for us: https://hg.mozilla.org/mozilla-central/rev/1a6a5662822d. Taking this for the upcoming alpha then.

Okay, this got some testing over there in https://bugzilla.mozilla.org/show_bug.cgi?id=1365047 in a ESR 52 context. I therefore just pushed the fix to tor-browser-52.3.0esr-7.5-2 (commit 1eeaa470e06b7538a961b2f33dddaeafdcc456fd). We can backport it next time in case nothing explodes.

Trac:
Status: new to closed
Keywords: N/A deleted, tbb-backport added
Resolution: N/A to fixed

The Q&A ticket is #23600 (moved).

Thanks, cypherpunk for bringing this up.

Neat, but aren't you experiencing this https://bugzilla.mozilla.org/show_bug.cgi?id=1380103 or any of these https://bugzilla.mozilla.org/show_bug.cgi?id=1394433?

The latter (the warnings bug) should not break compilation.

It does not break compilation, so we are good in that regard without taking additional patches.

Replying to gk:

It does not break compilation, so we are good in that regard without taking additional patches. https://bugzilla.mozilla.org/show_bug.cgi?id=1049366 is obsolete then.

What about https://bugzilla.mozilla.org/show_bug.cgi?id=1344921?

Backported with commit 979accc19fb297b0e73c515924d5dfe5c8236be4 on tor-browser-52.4.1esr-7.0-1. This will make it into Tor Browser 7.0.10.

Trac:
Keywords: tbb-backport deleted, tbb-backported added

closed

mentioned in issue #23600 (moved)

mentioned in issue tpo/applications/tor-browser-bundle-testsuite#23600

moved to tpo/applications/tor-browser#23582 (closed)