Opened 7 months ago

Closed 7 months ago

Last modified 5 months ago

#23582 closed defect (fixed)

Increased crash rate due to disabled Windows DLL blocklist

Reported by: cypherpunks Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201709, GeorgKoppen201709, tbb-backported
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Maybe, somebody (from Mozilla?) adapt it to mingw-w64.
Mozilla has a test for it, and "a failure in this test is considered a release blocker."

Child Tickets

Change History (12)

comment:1 Changed 7 months ago by gk

Status: newneeds_information

What makes you believe the Windows DLL blocklist is disabled in Tor Browser?

comment:2 Changed 7 months ago by cypherpunks

Status: needs_informationnew

Obviously,

#if defined(_MSC_VER) && (defined(_M_IX86) || defined(_M_X64))
#define HAS_DLL_BLOCKLIST

comment:3 in reply to:  2 Changed 7 months ago by gk

Keywords: TorBrowserTeam201709 GeorgKoppen201709 added

Replying to cypherpunks:

Obviously,

#if defined(_MSC_VER) && (defined(_M_IX86) || defined(_M_X64))
#define HAS_DLL_BLOCKLIST

Interesting but that's not something that's new. (Like included with the ESR 52 release). But we can test whether it works with mingw-w64 builds as well and ship it in that case.

comment:4 Changed 7 months ago by gk

Heh, it turns out tjr landed that one already for us: https://hg.mozilla.org/mozilla-central/rev/1a6a5662822d. Taking this for the upcoming alpha then.

comment:5 Changed 7 months ago by gk

Keywords: tbb-backport added
Resolution: fixed
Status: newclosed

Okay, this got some testing over there in https://bugzilla.mozilla.org/show_bug.cgi?id=1365047 in a ESR 52 context. I therefore just pushed the fix to tor-browser-52.3.0esr-7.5-2 (commit 1eeaa470e06b7538a961b2f33dddaeafdcc456fd). We can backport it next time in case nothing explodes.

comment:6 Changed 7 months ago by gk

The Q&A ticket is #23600.

Thanks, cypherpunk for bringing this up.

comment:8 Changed 7 months ago by tom

The latter (the warnings bug) should not break compilation.

comment:9 Changed 7 months ago by gk

It does not break compilation, so we are good in that regard without taking additional patches.

comment:10 in reply to:  9 Changed 7 months ago by cypherpunks

Replying to gk:

It does not break compilation, so we are good in that regard without taking additional patches.

https://bugzilla.mozilla.org/show_bug.cgi?id=1049366 is obsolete then.

comment:12 Changed 5 months ago by gk

Keywords: tbb-backported added; tbb-backport removed

Backported with commit 979accc19fb297b0e73c515924d5dfe5c8236be4 on tor-browser-52.4.1esr-7.0-1. This will make it into Tor Browser 7.0.10.

Note: See TracTickets for help on using tickets.