#23585 closed defect (fixed)

Build is failing with runc version 1.0.0-rc2

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201710R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I have been able to do builds with runc 0.1.1 (from Debian jessie backports, and from stretch), and runc 1.0.1 from Fedora 25. Matt reported on the tbb-dev mailing list that it is not working with version 1.0.0~rc2:
https://lists.torproject.org/pipermail/tbb-dev/2017-September/000615.html

It seems version 1.0.0~rc2 is half between version 0.1.1 and 1.0.0.

It was released after this commit, so it uses the same commands as 1.0.0:
https://github.com/opencontainers/runc/commit/c669b8d1568633c68bd915561ceb2e5ecc1bfc6a

However it seems to expect a config.json file in the same format as 0.1.1.

Child Tickets

Change History (4)

comment:2 Changed 21 months ago by boklm

#23754 is a duplicate.

comment:3 Changed 21 months ago by boklm

Keywords: TorBrowserTeam201710R added; TorBrowserTeam201709 removed
Status: assignedneeds_review

I pushed branch bug_23585_v2 which contains the same patch rebased on master:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_23585_v2&id=8c4c05ddcfc30107b967b204d491523685460226

This patch fixed the problem in #23754.

comment:4 Changed 21 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. Merged to master with commit 8c4c05ddcfc30107b967b204d491523685460226.

Note: See TracTickets for help on using tickets.