Changes between Initial Version and Version 1 of Ticket #23588, comment 29


Ignore:
Timestamp:
Aug 11, 2018, 9:54:26 PM (6 months ago)
Author:
neel
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23588, comment 29

    initial v1  
     1Surprisingly the code did not crash on my laptop (FreeBSD 12), but did on my desktop (FreeBSD 12 again) and on a VM (Debian 9).
     2
    13I figured out how to get fix the bug, however, with a catch: instead of using `fascist_firewall_choose_address_base()` to choose the address in `fascist_firewall_choose_address_ls()`, I do it manually with:
    24
     
    1214
    1315Would this be okay?
     16
     17This code goes in place of `fascist_firewall_choose_address_base()` in `fascist_firewall_choose_address_ls()`. This passes `make test-network-all`.
     18
     19These changes are now pushed. A copy old branch (before the change) is here: https://github.com/neelchauhan/tor/tree/b23588a_old
     20
     21**UPDATE:** Make comment more descriptive and announce the push.