Changes between Initial Version and Version 1 of Ticket #23588, comment 36


Ignore:
Timestamp:
Aug 15, 2018, 2:11:03 AM (12 months ago)
Author:
neel
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23588, comment 36

    initial v1  
    1 I think I know what the bug for `hs-v23-ipv6-md` is: some addresses are being marked as they don't make it through `fascist_firewall_allows_address_ap()` (I believe the main Tor codebase does not make addresses go though this now, nor does my old "simplified" address choosing code that got abandoned).
     1I think I know what the bug for `hs-v23-ipv6-md` is: some addresses are being marked as invalid as they don't make it through `fascist_firewall_allows_address_ap()` (I believe the main Tor codebase does not make addresses go though this now, nor does my old "simplified" address choosing code that got abandoned).
    22
    33A solution can be to add a flag like `verify_addr` to `fascist_firewall_choose_address_impl()`, `fascist_firewall_choose_address()`, and `fascist_firewall_choose_address_base()` that determines whether we should verify the addresses or not, and set this flag to `0` in `fascist_firewall_choose_address_ls()`'s call to `fascist_firewall_choose_address_base()` and `1` in other calls.