Opened 8 months ago

Closed 7 months ago

#23589 closed defect (fixed)

Stop assuming that every extend_info contains an IPv4 address in get_lspecs_from_extend_info()

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version: Tor: 0.3.2.1-alpha
Severity: Normal Keywords: prop224, tor-hs, single-onion, ipv6
Cc: neel@… Actual Points: 0.2
Parent ID: #23820 Points: 0.2
Reviewer: Sponsor:

Description

addr can be an IPv6 address

Child Tickets

Change History (6)

comment:1 Changed 8 months ago by teor

Milestone: Tor: 0.3.2.x-finalTor: 0.3.3.x-final

These tickets aren't urgent, and they involve major refactoring.
Deferring to 0.3.3

comment:2 Changed 8 months ago by teor

This is safe, because all client extend infos are IPv4.

Even if they are not, if addr is an IPv6 address, the IPv4 address ends up being 0.0.0.0. And it gets rejected in hs_get_extend_info_from_lspecs() by extend_info_addr_is_allowed().

comment:3 Changed 7 months ago by teor

Actual Points: 0.2
Milestone: Tor: 0.3.3.x-finalTor: 0.3.2.x-final
Parent ID: #23493#23820
Points: 0.2
Status: newneeds_review
Version: Tor: 0.3.2.1-alpha

In my commit ab53577d8c in my branch bug23820_032 (#23820), I fixed this issue.
(We will add IPv6 support to that function in #23577.)

comment:4 Changed 7 months ago by neel

Cc: neel@… added

comment:5 Changed 7 months ago by dgoulet

Owner: set to teor
Status: needs_reviewassigned

Assigning this to "teor". In theory, this will be fixed by #23820 so change its status so it doesn't end up in the next review group :).

comment:6 Changed 7 months ago by dgoulet

Resolution: fixed
Status: assignedclosed

Merged via #23820

Note: See TracTickets for help on using tickets.