Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#23598 closed defect (duplicate)

Bump pyOpenSSL in BridgeDB to 16.2.0

Reported by: gk Owned by: isis
Priority: Medium Milestone:
Component: Circumvention/BridgeDB Version:
Severity: Normal Keywords:
Cc: Actual Points: .1
Parent ID: Points: .1
Reviewer: Sponsor: SponsorM

Description (last modified by gk)

When doing e.g. pip install -r .test.requirements.txt (with OpenSSL 1.1.0f) one gets

Traceback (most recent call last):
  File "/home/thomas/.virtualenvs/bridgedb/bin/pip", line 7, in <module>
    from pip import main
  File "/home/thomas/.virtualenvs/bridgedb/lib/python2.7/site-packages/pip/__init__.py", line 21, in <module>
    from pip._vendor.requests.packages.urllib3.exceptions import DependencyWarning
  File "/home/thomas/.virtualenvs/bridgedb/lib/python2.7/site-packages/pip/_vendor/__init__.py", line 64, in <module>
    vendored("cachecontrol")
  File "/home/thomas/.virtualenvs/bridgedb/lib/python2.7/site-packages/pip/_vendor/__init__.py", line 36, in vendored
    __import__(modulename, globals(), locals(), level=0)
  File "/home/thomas/.virtualenvs/bridgedb/share/python-wheels/CacheControl-0.11.7-py2.py3-none-any.whl/cachecontrol/__init__.py", line 9, in <module>
  File "/home/thomas/.virtualenvs/bridgedb/share/python-wheels/CacheControl-0.11.7-py2.py3-none-any.whl/cachecontrol/wrapper.py", line 1, in <module>
  File "/home/thomas/.virtualenvs/bridgedb/share/python-wheels/CacheControl-0.11.7-py2.py3-none-any.whl/cachecontrol/adapter.py", line 4, in <module>
  File "/home/thomas/.virtualenvs/bridgedb/share/python-wheels/requests-2.12.4-py2.py3-none-any.whl/requests/__init__.py", line 52, in <module>
  File "/home/thomas/.virtualenvs/bridgedb/share/python-wheels/requests-2.12.4-py2.py3-none-any.whl/requests/packages/__init__.py", line 59, in <module>
  File "/home/thomas/.virtualenvs/bridgedb/share/python-wheels/requests-2.12.4-py2.py3-none-any.whl/requests/packages/__init__.py", line 32, in vendored
  File "/home/thomas/.virtualenvs/bridgedb/share/python-wheels/urllib3-1.19.1-py2.py3-none-any.whl/urllib3/contrib/pyopenssl.py", line 47, in <module>
  File "/home/thomas/.virtualenvs/bridgedb/lib/python2.7/site-packages/OpenSSL/__init__.py", line 8, in <module>
    from OpenSSL import rand, crypto, SSL
  File "/home/thomas/.virtualenvs/bridgedb/lib/python2.7/site-packages/OpenSSL/SSL.py", line 105, in <module>
    SSL_ST_INIT = _lib.SSL_ST_INIT
AttributeError: 'module' object has no attribute 'SSL_ST_INIT'

This is essentially https://github.com/pyca/pyopenssl/issues/525.

Child Tickets

Attachments (1)

0001-Bump-pyOpenSSL-version-to-16.2.0.patch (855 bytes) - added by gk 2 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 2 years ago by gk

Component: - Select a componentObfuscation/BridgeDB
Owner: set to isis

comment:2 Changed 2 years ago by gk

Description: modified (diff)

comment:3 Changed 2 years ago by gk

Status: newneeds_review

comment:4 in reply to:  description Changed 2 years ago by isis

Actual Points: .1
Points: .1
Resolution: duplicate
Sponsor: SponsorM
Status: needs_reviewclosed

Replying to gk:

When doing e.g. pip install -r .test.requirements.txt (with OpenSSL 1.1.0f) one gets


Hi! Thanks for reporting this! I'm a little bit confused because .test.requirements.txt doesn't list PyOpenSSL as a dependency (the whole point of that file is so that the Travis CI setup can test a matrix of different versions of Twisted and PyOpenSSL, see the install: stanza in .travis.yml and the script at scripts/install-dependencies that it executes).

Traceback (most recent call last):
  File "/home/thomas/.virtualenvs/bridgedb/bin/pip", line 7, in <module>
    from pip import main
  File "/home/thomas/.virtualenvs/bridgedb/lib/python2.7/site-packages/pip/__init__.py", line 21, in <module>
    from pip._vendor.requests.packages.urllib3.exceptions import DependencyWarning
  File "/home/thomas/.virtualenvs/bridgedb/lib/python2.7/site-packages/pip/_vendor/__init__.py", line 64, in <module>
    vendored("cachecontrol")
  File "/home/thomas/.virtualenvs/bridgedb/lib/python2.7/site-packages/pip/_vendor/__init__.py", line 36, in vendored
    __import__(modulename, globals(), locals(), level=0)
  File "/home/thomas/.virtualenvs/bridgedb/share/python-wheels/CacheControl-0.11.7-py2.py3-none-any.whl/cachecontrol/__init__.py", line 9, in <module>
  File "/home/thomas/.virtualenvs/bridgedb/share/python-wheels/CacheControl-0.11.7-py2.py3-none-any.whl/cachecontrol/wrapper.py", line 1, in <module>
  File "/home/thomas/.virtualenvs/bridgedb/share/python-wheels/CacheControl-0.11.7-py2.py3-none-any.whl/cachecontrol/adapter.py", line 4, in <module>
  File "/home/thomas/.virtualenvs/bridgedb/share/python-wheels/requests-2.12.4-py2.py3-none-any.whl/requests/__init__.py", line 52, in <module>
  File "/home/thomas/.virtualenvs/bridgedb/share/python-wheels/requests-2.12.4-py2.py3-none-any.whl/requests/packages/__init__.py", line 59, in <module>
  File "/home/thomas/.virtualenvs/bridgedb/share/python-wheels/requests-2.12.4-py2.py3-none-any.whl/requests/packages/__init__.py", line 32, in vendored
  File "/home/thomas/.virtualenvs/bridgedb/share/python-wheels/urllib3-1.19.1-py2.py3-none-any.whl/urllib3/contrib/pyopenssl.py", line 47, in <module>
  File "/home/thomas/.virtualenvs/bridgedb/lib/python2.7/site-packages/OpenSSL/__init__.py", line 8, in <module>
    from OpenSSL import rand, crypto, SSL
  File "/home/thomas/.virtualenvs/bridgedb/lib/python2.7/site-packages/OpenSSL/SSL.py", line 105, in <module>
    SSL_ST_INIT = _lib.SSL_ST_INIT
AttributeError: 'module' object has no attribute 'SSL_ST_INIT'

This is essentially https://github.com/pyca/pyopenssl/issues/525.


The other thing is that the PyOpenSSL dependency listed in requirements.txt was updated as part of #22998 in commit 0ae12639c. Sorry for the trouble! I'm closing as a duplicate, but feel free to reopen if I misunderstood.

comment:5 Changed 2 years ago by gk

I am fine if that's a duplicate (and btw: I really got this traceback by just following the README and trying to run the tests/getting the requirements installed). What is confusing is that master is not the branch to write patches against (i.e. not the one containing the latest code). Which other canonical branch is the right one to use if one wants to do development and write patches for issues popping up?

Note: See TracTickets for help on using tickets.