Opened 4 weeks ago

Closed 4 weeks ago

#23607 closed defect (fixed)

Avoid assertion failure for state file clock skew

Reported by: catalyst Owned by: catalyst
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: bootstrap clock-skew regression
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by catalyst)

The clock_skew_warning() refactoring can cause an assertion failure when or_state_load() calls to control_event_bootstrap_problem() (via clock_skew_warning() prior to bootstrap phase 0.

We should initialize the bootstrap state first.

Child Tickets

Change History (3)

comment:1 Changed 4 weeks ago by catalyst

Status: assignedneeds_review

Proposed fix in https://oniongit.eu/catalyst/tor/merge_requests/5
Note this also includes the patch for #23606. Thanks to arma for suggesting this approach.

comment:2 Changed 4 weeks ago by catalyst

Description: modified (diff)
Keywords: bootstrap clock-skew regression added
Summary: control_event_bootstrap_problem() should ignore "early" problems instead of assertingAvoid assertion failure for state file clock skew

Adjust description to match the narrower scope of the fix.

comment:3 Changed 4 weeks ago by nickm

Resolution: fixed
Status: needs_reviewclosed

lgtm; merging!

Note: See TracTickets for help on using tickets.