Changes between Initial Version and Version 2 of Ticket #23607


Ignore:
Timestamp:
Sep 21, 2017, 1:42:14 PM (2 years ago)
Author:
catalyst
Comment:

Adjust description to match the narrower scope of the fix.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23607

    • Property Status changed from assigned to needs_review
    • Property Keywords bootstrap clock-skew regression added
    • Property Summary changed from control_event_bootstrap_problem() should ignore "early" problems instead of asserting to Avoid assertion failure for state file clock skew
  • Ticket #23607 – Description

    initial v2  
    1 The `clock_skew_warning()` refactoring can allow calls to `control_event_bootstrap_problem()` prior to bootstrap phase 0, causing an assertion failure.  (Clock skew in a state file is one possibility.)  Instead of asserting, ignore such calls, because they seem to always have another logging path.
     1The `clock_skew_warning()` refactoring can cause an assertion failure when `or_state_load()` calls to `control_event_bootstrap_problem()` (via `clock_skew_warning()` prior to bootstrap phase 0.
     2
     3We should initialize the bootstrap state first.