Opened 3 years ago

Closed 3 years ago

#23608 closed defect (fixed)

Some channelpadidng tests still use unmocked time

Reported by: mikeperry Owned by: mikeperry
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: nickm, weasel Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


I missed a couple tests in my rush to get the patch done for the merge window. Embarrassing. Patch to follow shortly.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by mikeperry

Status: assignedneeds_review

Ok. The patch is in mikeperry/bug23608 (d7e9f7b6633cd1d1975d252063c095478da909f1). I mock time for all the tests now, even the ones that don't use timers. Just in case.

comment:2 Changed 3 years ago by nickm

Milestone: Tor: 0.3.1.x-final

comment:3 Changed 3 years ago by nickm

Cc: weasel added
Resolution: fixed
Status: needs_reviewclosed

Cherry-picked to maint-0.3.1 and merged forward. Thanks, Mike!

Weasel, this should fix the sparc64 test failure you reported.

Note: See TracTickets for help on using tickets.