Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#2363 closed defect (fixed)

evdns_base_resolve_* macros are bogus

Reported by: rransom Owned by:
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: easy tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

2011-01-08 08:59 <lodger> non-libevent2's evdns_resolve_*() funcs returns (1) for error. Tor-alpha waiting for -1 as for libevent2 case. dns.c defines evdns_base_resolve_*() errorly for non-libevent2 case.

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by nickm

Keywords: easy added
Priority: criticalnormal
Status: newneeds_review

Fix for review in branch "bug2363" in my public repository.

comment:2 in reply to:  1 Changed 8 years ago by rransom

Replying to nickm:

Fix for review in branch "bug2363" in my public repository.

Looks good.

comment:3 Changed 8 years ago by cypherpunks

Note that this broken check was not for _resolve_ failures or even for
failures to _launch_ a resolve: it was for failures to _create_ or
_encode_ a resolve request.

Yup. It's a failures that trigerable remotely, easy. Relay has a memleak after such, at least.

comment:4 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged to 0.2.2 and master

comment:5 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:6 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.