Opened 4 weeks ago

Closed 4 weeks ago

#23645 closed defect (fixed)

hs: Continue to improve logging in both HS and circuit subsystems

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, tor-circuit, logging
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Having #23604 merged has already paid off big time.

This ticket is about going for a second iteration on improving logging overall with circuits and hidden service.

There are actually two bugs with #23604 (nothing serious) so this ticket will also address it.

Child Tickets

Change History (4)

comment:1 Changed 4 weeks ago by dgoulet

Status: assignedneeds_review

See branch: ticket23645_032_01.

That n_circ_id and globale_identifier needs to be a pair in the logs so we can match from allocation to freeing it correctly else it's a guessing game.

comment:2 Changed 4 weeks ago by asn

Status: needs_reviewmerge_ready

Please see branch ticket23645_032_01 in my repo. It contains David's branch, plus it fixes a unittest that was expecting the wrong logs, plus it silences another annoying warning.

comment:3 Changed 4 weeks ago by nickm

Status: merge_readyneeds_revision

This needs a changes file; also, the tests don't pass for me:

hs_service/build_update_descriptors: [forking] 
  FAIL src/test/test_hs_service.c:1154: expected log to contain "just picked 1 intro points and wanted 3. It " "currently has 0 intro points. Launching " "ESTABLISH_INTRO circuit shortly."  Captured logs:

asn, is it possible that you didn't commit some of your changes on your branch? I don't see any unit test fixes in this branch.

comment:4 Changed 4 weeks ago by nickm

Resolution: fixed
Status: needs_revisionclosed

thanks for the fix; I'm adding a changes file and merging.

Note: See TracTickets for help on using tickets.