Opened 8 months ago

Closed 4 months ago

Last modified 3 months ago

#23650 closed defect (fixed)

Tor source code has many typos

Reported by: cypherpunks Owned by: arma
Priority: Very Low Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Trivial Keywords: easy, review-group-31
Cc: fristonio Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

$ go get -u github.com/client9/misspell/cmd/misspell
$ misspell .
.gitlab-ci.yml:23:14: "suspectible" is a misspelling of "susceptible"
changes/bug23580:2:49: "mentionning" is a misspelling of "mentioning"
contrib/operator-tools/linux-tor-prio.sh:90:59: "trafic" is a misspelling of "traffic"
configure.ac:535:10: "targetting" is a misspelling of "targeting"
doc/HACKING/GettingStartedRust.md:119:17: "targetting" is a misspelling of "targeting"
doc/HACKING/Tracing.md:9:17: "seperated" is a misspelling of "separated"
m4/pkg.m4:56:20: "occurence" is a misspelling of "occurrence"
scripts/maint/redox.py:104:35: "alledgedly" is a misspelling of "allegedly"
src/common/compat_openssl.h:15:10: "compatability" is a misspelling of "compatibility"
src/common/address.c:1126:23: "comapre" is a misspelling of "compare"
src/common/compat.c:2447:3: "successfull" is a misspelling of "successful"
src/common/crypto_ed25519.c:228:28: "occured" is a misspelling of "occurred"
src/common/crypto_ed25519.c:262:18: "successfuly" is a misspelling of "successfully"
src/common/crypto_ed25519.c:526:30: "sucess" is a misspelling of "success"
src/common/crypto_ed25519.c:716:13: "cannonical" is a misspelling of "canonical"
src/common/crypto_ed25519.c:756:50: "neccessary" is a misspelling of "necessary"
scripts/maint/updateFallbackDirs.py:214:52: "multipled" is a misspelling of "multiplied"
scripts/maint/updateFallbackDirs.py:550:34: "bandwdith" is a misspelling of "bandwidth"
scripts/maint/updateFallbackDirs.py:1553:35: "bandwdith" is a misspelling of "bandwidth"
src/common/crypto.c:1527:3: "sucess" is a misspelling of "success"
src/common/crypto.c:2835:35: "foward" is a misspelling of "forward"
src/common/crypto.c:2848:5: "comparision" is a misspelling of "comparison"
src/common/timers.c:66:39: "inefficent" is a misspelling of "inefficient"
src/common/tortls.c:1941:34: "intial" is a misspelling of "initial"
src/ext/curve25519_donna/README:9:0: "dependancies" is a misspelling of "dependencies"
doc/tor.1.txt:2416:26: "simultanous" is a misspelling of "simultaneous"
doc/tor.1.txt:2831:4: "decribing" is a misspelling of "describing"
src/ext/ed25519/donna/README.md:59:25: "aginst" is a misspelling of "against"
src/ext/ed25519/donna/README.md:76:25: "aginst" is a misspelling of "against"
src/ext/ed25519/donna/ed25519_tor.c:135:45: "implementaion" is a misspelling of "implementation"
src/common/util.c:3048:18: "sucess" is a misspelling of "success"
src/common/util.c:3899:46: "accomodate" is a misspelling of "accommodate"
src/common/util.c:3929:10: "processs" is a misspelling of "processes"
src/or/bridges.c:354:40: "adress" is a misspelling of "address"
src/or/circpathbias.c:1470:3: "transfered" is a misspelling of "transferred"
src/or/circpathbias.c:1530:3: "transfered" is a misspelling of "transferred"
src/or/circuitlist.c:739:24: "rendevous" is a misspelling of "rendezvous"
src/or/circuitlist.c:741:24: "rendevous" is a misspelling of "rendezvous"
src/or/circuitstats.c:167:58: "paramter" is a misspelling of "parameter"
src/or/circuitstats.c:194:55: "paramter" is a misspelling of "parameter"
src/or/circuitstats.c:221:55: "paramter" is a misspelling of "parameter"
src/or/circuitstats.c:253:55: "paramter" is a misspelling of "parameter"
src/or/circuitstats.c:277:60: "paramter" is a misspelling of "parameter"
src/or/circuitstats.c:309:55: "paramter" is a misspelling of "parameter"
src/or/circuitstats.c:356:61: "paramter" is a misspelling of "parameter"
src/or/circuitstats.c:386:58: "paramter" is a misspelling of "parameter"
src/or/connection.c:4129:46: "owernship" is a misspelling of "ownership"
src/or/connection.c:4139:46: "owernship" is a misspelling of "ownership"
src/or/config.c:2901:28: "occurances" is a misspelling of "occurrences"
src/or/dirserv.c:46:13: "reponsible" is a misspelling of "responsible"
src/or/dirserv.c:1089:18: "bandwith" is a misspelling of "bandwidth"
src/or/dirserv.h:126:45: "encrytped" is a misspelling of "encrypted"
src/or/dirvote.c:666:48: "accidently" is a misspelling of "accidentally"
src/or/control.c:4695:5: "Succeded" is a misspelling of "Succeeded"
src/or/dns.c:22:38: "rela" is a misspelling of "real"
src/or/hs_cache.c:693:28: "explicitely" is a misspelling of "explicitly"
src/or/hs_cache.c:778:28: "explicitely" is a misspelling of "explicitly"
src/or/hs_client.c:540:5: "Explicitely" is a misspelling of "Explicitly"
src/or/hs_config.c:553:38: "transfered" is a misspelling of "transferred"
src/or/directory.c:1155:27: "determins" is a misspelling of "determines"
src/or/directory.c:1166:27: "determins" is a misspelling of "determines"
src/or/directory.c:3433:54: "successfuly" is a misspelling of "successfully"
src/or/directory.c:4072:7: "prefered" is a misspelling of "preferred"
src/or/directory.c:4984:19: "seperator" is a misspelling of "separator"
src/or/hs_intropoint.c:427:43: "occured" is a misspelling of "occurred"
src/or/hs_common.c:1645:32: "prefered" is a misspelling of "preferred"
src/or/hs_common.c:1646:28: "prefered" is a misspelling of "preferred"
src/or/hs_descriptor.c:748:12: "occured" is a misspelling of "occurred"
src/or/hs_descriptor.c:805:40: "occured" is a misspelling of "occurred"
src/or/hs_descriptor.c:1602:22: "accomodate" is a misspelling of "accommodate"
src/or/onion_fast.c:26:19: "targetted" is a misspelling of "targeted"
src/or/reasons.c:431:39: "bandwidht" is a misspelling of "bandwidth"
src/or/rendcache.c:46:60: "unsuable" is a misspelling of "unusable"
src/or/rendcache.c:51:32: "realy" is a misspelling of "really"
src/or/rendcache.h:39:35: "occured" is a misspelling of "occurred"
src/or/hs_service.c:73:59: "seperated" is a misspelling of "separated"
src/or/hs_service.c:140:22: "transfered" is a misspelling of "transferred"
src/or/hs_service.c:254:49: "accomodate" is a misspelling of "accommodate"
src/or/hs_service.c:267:49: "accomodate" is a misspelling of "accommodate"
src/or/hs_service.c:284:49: "accomodate" is a misspelling of "accommodate"
src/or/hs_service.c:301:49: "accomodate" is a misspelling of "accommodate"
src/or/hs_service.c:1269:45: "fomr" is a misspelling of "from"
src/or/hs_service.c:1299:3: "Populare" is a misspelling of "Popular"
src/or/hs_service.c:3008:5: "succesful" is a misspelling of "successful"
src/or/rendclient.c:572:58: "choosen" is a misspelling of "chosen"
ReleaseNotes:1348:36: "detailled" is a misspelling of "detailed"
ReleaseNotes:5106:11: "occured" is a misspelling of "occurred"
ReleaseNotes:5579:23: "targetted" is a misspelling of "targeted"
ReleaseNotes:6756:6: "embarassing" is a misspelling of "embarrassing"
ReleaseNotes:6780:18: "documenation" is a misspelling of "documentation"
ReleaseNotes:8923:10: "absense" is a misspelling of "absence"
ReleaseNotes:10036:44: "arbitary" is a misspelling of "arbitrary"
ReleaseNotes:15225:33: "occassionally" is a misspelling of "occasionally"
ReleaseNotes:15344:36: "maintainance" is a misspelling of "maintenance"
src/or/rendservice.h:111:28: "simultanious" is a misspelling of "simultaneous"
src/or/policies.c:2369:11: "rougly" is a misspelling of "roughly"
src/or/rephist.c:2734:12: "Incrememnts" is a misspelling of "Increments"
src/or/shared_random.c:1074:8: "substract" is a misspelling of "subtract"
src/or/shared_random_state.c:1100:23: "transfered" is a misspelling of "transferred"
src/or/shared_random_state.c:1119:23: "transfered" is a misspelling of "transferred"
src/or/shared_random_state.c:1224:3: "transfered" is a misspelling of "transferred"
src/or/rendservice.c:1335:16: "sucess" is a misspelling of "success"
src/or/rendservice.c:3169:5: "Substract" is a misspelling of "Subtract"
src/or/rendservice.c:4085:17: "choosen" is a misspelling of "chosen"
src/or/routerlist.c:366:24: "downlaods" is a misspelling of "downloads"
src/or/routerlist.c:2636:52: "authorites" is a misspelling of "authorities"
src/or/transports.c:593:7: "futher" is a misspelling of "further"
src/or/or.h:3089:35: "artifically" is a misspelling of "artificially"
src/or/or.h:3347:19: "paramaters" is a misspelling of "parameters"
src/or/or.h:4100:33: "alwasy" is a misspelling of "always"
src/test/test.c:177:21: "procede" is a misspelling of "proceed"
src/test/test_conscache.c:44:40: "planetas" is a misspelling of "planets"
src/test/test_connection.c:782:41: "varaible" is a misspelling of "variable"
src/test/test_cell_formats.c:480:15: "acutally" is a misspelling of "actually"
src/test/test_channelpadding.c:445:22: "recieve" is a misspelling of "receive"
src/test/test_channelpadding.c:515:22: "recieve" is a misspelling of "receive"
src/test/test_channelpadding.c:814:43: "suport" is a misspelling of "support"
src/test/test_channelpadding.c:825:40: "suport" is a misspelling of "support"
src/test/test_hs.c:1012:33: "transfered" is a misspelling of "transferred"
src/test/test_entrynodes.c:1997:49: "confirmd" is a misspelling of "confirmed"
src/test/test_config.c:326:19: "shoudl" is a misspelling of "should"
src/test/test_config.c:1394:41: "succeds" is a misspelling of "succeeds"
src/test/test_hs_descriptor.c:416:5: "Seperate" is a misspelling of "Separate"
src/test/test_extorport.c:246:58: "ther" is a misspelling of "there"
src/test/test_hs_intropoint.c:142:18: "extentions" is a misspelling of "extensions"
src/test/test_hs_intropoint.c:555:4: "Successfuly" is a misspelling of "Successfully"
src/test/test_dir.c:1273:19: "comapre" is a misspelling of "compare"
src/test/test_hs_service.c:663:66: "successfuly" is a misspelling of "successfully"
src/test/test_microdesc.c:574:6: "expolding" is a misspelling of "exploding"
src/test/test_shared_random.c:427:44: "seperately" is a misspelling of "separately"
src/test/test_shared_random.c:637:52: "agains" is a misspelling of "against"
src/test/test_options.c:908:54: "existant" is a misspelling of "existent"
src/test/test_options.c:920:54: "existant" is a misspelling of "existent"
src/test/test_options.c:932:55: "existant" is a misspelling of "existent"
src/test/test_options.c:944:55: "existant" is a misspelling of "existent"
src/test/test_options.c:1114:52: "existant" is a misspelling of "existent"
src/trunnel/hs/cell_introduce1.trunnel:17:36: "explicitely" is a misspelling of "explicitly"
src/test/test_util.c:706:43: "millenia" is a misspelling of "millennia"
src/test/test_util.c:742:43: "millenia" is a misspelling of "millennia"
src/test/test_util.c:878:43: "millenia" is a misspelling of "millennia"
src/test/test_util.c:924:43: "millenia" is a misspelling of "millennia"
src/test/test_util.c:5348:41: "exersize" is a misspelling of "exercise"
ChangeLog:3045:36: "detailled" is a misspelling of "detailed"
ChangeLog:6513:11: "occured" is a misspelling of "occurred"
ChangeLog:7256:23: "targetted" is a misspelling of "targeted"
ChangeLog:8399:18: "documenation" is a misspelling of "documentation"
ChangeLog:9684:6: "embarassing" is a misspelling of "embarrassing"
ChangeLog:9785:38: "occured" is a misspelling of "occurred"
ChangeLog:12576:32: "acknowleged" is a misspelling of "acknowledge"
ChangeLog:13883:10: "absense" is a misspelling of "absence"
ChangeLog:16384:50: "occured" is a misspelling of "occurred"
ChangeLog:16798:44: "arbitary" is a misspelling of "arbitrary"
ChangeLog:19826:22: "concensus" is a misspelling of "consensus"
ChangeLog:23213:33: "occassionally" is a misspelling of "occasionally"
ChangeLog:23678:36: "maintainance" is a misspelling of "maintenance"

Child Tickets

Attachments (1)

0001-Fix-spelling-mistakes-corresponding-to-ticket-23650.patch (84.4 KB) - added by fristonio 4 months ago.
Fix typos in tor source code.

Download all attachments as: .zip

Change History (27)

comment:1 Changed 8 months ago by arma

Big fan.

I'll note that this anonymous person just picked me as the owner of the ticket, and that's not actually the same as making me the owner of the ticket.

If somebody wants to do up a branch on master for these, that would be great.

Also, we should make sure that we don't accidentally try to fix any typos that made it into the actual protocol, a la "Dependant" in control-spec.txt. Or at least, if we do we should fix them more thoroughly.

comment:2 Changed 8 months ago by nickm

Milestone: Tor: 0.3.3.x-final

comment:3 Changed 7 months ago by teor

We need to check each of these in context, because I bet this one is actually a misspelling of "relay":

src/or/dns.c:22:38: "rela" is a misspelling of "real"

comment:4 Changed 5 months ago by dgoulet

Keywords: easy added
Milestone: Tor: 0.3.3.x-finalTor: unspecified
Status: assignednew

If arma is not going to do it, put it back in New so someone can pick it up by looking at those only.

comment:5 Changed 4 months ago by fristonio

Hey,

I am new to the tor communtiy and would really like contribute, can I take up this ticket, would be a good place to start off with. :)

comment:6 Changed 4 months ago by teor

This would be a great place to start!

Just watch out, some of the suggestions are wrong:

src/or/dns.c:22:38: "rela" is a misspelling of "real"
src/or/rendcache.c:51:32: "realy" is a misspelling of "really"

These are probably misspellings of "relay".

Please attach a patch to this ticket, or tell us where your git branch is.

Once we have fixed all of these, our next step is to work out how to run a spelling check regularly as part of "make check".

comment:7 Changed 4 months ago by fristonio

Yeah, that make check part would be great. Will try to create the patch as soon as possible.

comment:8 Changed 4 months ago by teor

When we do patches for mass changes like this, we keep the large change separate from any ongoing checks.

comment:9 Changed 4 months ago by fristonio

@teor should I also change spellings in ChangeLogs and ReleaseNotes, aren't they autogenerated?

comment:10 Changed 4 months ago by teor

We use a script to combine changes files into the ChangeLog and ReleaseNotes.
You can fix misspellings in them.

Oh, and remember to base your branch on our master branch.
Modifying the ChangeLog and ReleaseNotes in older versions gets messy,

comment:11 Changed 4 months ago by fristonio

OK, also

comment:12 Changed 4 months ago by fristonio

Cc: fristonio added

comment:13 in reply to:  11 Changed 4 months ago by arma

Replying to fristonio:

OK, also

I would say yes.

I'd say no, leave this one as it is. (It appears that there are a bunch of strings, split between themselves, being all poetic and stuff.)

comment:14 Changed 4 months ago by fristonio

Ok, I have made almost all the required changes, one thing that I would like to know is how can I run all the tests so I can confirm that I accidentally didn't break something?

comment:15 Changed 4 months ago by teor

Run "make check"
You might need to run configure first, see the instructions in INSTALL

comment:16 Changed 4 months ago by fristonio

I'm on it, will upload the patch shortly. :)

comment:17 Changed 4 months ago by fristonio

There was an error in tests due to the correction of this spelling https://gitweb.torproject.org/tor.git/tree/src/test/test_microdesc.c#n574 . I guess there might be some comparison with the key string due to which test failed on changing the spelling so I am letting this one to persist if its ok.

comment:18 Changed 4 months ago by fristonio

I am ready with my patch, what is the preferred way to submit the patch, should I upload it to github on a gist or in a repository in my github profile or should I upload it here only? @teor @arma

Last edited 4 months ago by fristonio (previous) (diff)

Changed 4 months ago by fristonio

Fix typos in tor source code.

comment:19 Changed 4 months ago by fristonio

Here is link to the patch on my GitHub repository : https://github.com/fristonio/tor-patches/blob/master/0001-Fix-spelling-mistakes-corresponding-to-ticket-23650.patch

Thanks for your help @teor and @arma

comment:20 Changed 4 months ago by teor

Milestone: Tor: unspecifiedTor: 0.3.4.x-final
Status: newneeds_review

This should get reviewed in the next week or two.

comment:21 Changed 4 months ago by fristonio

Thanks, that would be great.
Should I go on for adding a spell check in make check, or meanwhile the ticket is reviewed I should look for solving other issues ?

comment:22 Changed 4 months ago by teor

It would be great to have a spell check in "make check". But it has to be optional, because not everyone has go installed.
(Is there a tool that doesn't require an entire go runtime?)

It's probably best to open another ticket, we'll get confused if there are two patches in here.

comment:23 Changed 4 months ago by fristonio

Yeah, also they provide a standalone binary for the same so we can use it for the typos check, I will open a new ticket for it and we can have this discussion there.

comment:24 Changed 4 months ago by nickm

Keywords: review-group-31 added

comment:25 Changed 4 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Okay, I've merged this, with the following exceptions and tweaks:

  • "planetas" in src/test/test_conscache is correct Spanish, to go along with "adios" earlier in that line. I think it's intentional.
  • "straight foward" in src/common/crypto.c should be "straightforward" (one word).
  • Some of the RSA functions had moved to crypto_rsa.c, so I had to hand-apply those change and the ones in crypto.c.
  • The following files are not maintained by us, so we shouldn't make trivial changes to them ourselves:
    • src/ext/curve25519_donna/README
    • src/ext/ed25519/donna/README.md
    • m4/pkg.m4
  • I added a changes file in a separate commit.
  • I wrapped some wide lines.

Thanks very much for the patch!

comment:26 Changed 3 months ago by fristonio

Thanks for merging, I am looking forward to contribute more :)

Note: See TracTickets for help on using tickets.