Opened 3 years ago

Closed 3 years ago

#23654 closed defect (fixed)

Fix ja dmg file name in tor-browser-build

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201709R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In tor-browser-bundle we were renaming the ja-JP-mac dmg file to ja, and this part was missing in tor-browser-build.

Child Tickets

Change History (2)

comment:1 Changed 3 years ago by boklm

Keywords: TorBrowserTeam201709R added
Status: new → needs_review

The branch bug_23654_v2 has a patch to fix that:
​https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_23654_v2&id=f42778f91a144375f29b2f584073e3b63b564553

I checked that it produce the correct change with:

./rbm/rbm showconf tor-browser build --target alpha --target torbrowser-osx-x86_64 --target no_build_id | less

The ja filename is used in the dmg filename, and ja-JP-mac is still used in all other places.

comment:2 Changed 3 years ago by gk

Resolution: → fixed
Status: needs_review → closed

Looks good to me, let's try it for -build5. Applied to master (commit f42778f91a144375f29b2f584073e3b63b564553).

Note: See TracTickets for help on using tickets.