#23670 closed enhancement (implemented)

Say how many primary entry guards we're missing descriptors for

Reported by: teor Owned by: asn
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-guard, tor-bridge, tor-client
Cc: catalyst, isis Actual Points:
Parent ID: #21969 Points: 0.5
Reviewer: Sponsor:

Description

Let's say:

We're missing descriptors for %d/%d of our primary entry guards

That would be a more helpful diagnostic for #21969.

Child Tickets

Change History (9)

comment:1 Changed 12 months ago by asn

+1

comment:2 Changed 12 months ago by asn

Owner: set to asn
Status: newassigned

comment:3 Changed 12 months ago by asn

Status: assignedneeds_review

Please see branch `bug23670` in my repo for the feature and a basic unittest.

comment:4 Changed 12 months ago by asn

Pushed two more commits implementing the #23671 feature as well, since they are very tightly coupled.

comment:5 Changed 12 months ago by nickm

Milestone: Tor: 0.3.3.x-finalTor: 0.3.2.x-final

comment:6 Changed 12 months ago by nickm

Two issues:

1) Changes file, please?
2) I think that the old function name name (entry_guards_have_enough_dir_info_to_build_circuits) was much more clear than (entry_guards_get_dir_info_status_str); it's not clear from the name of the new function that it checks whether there is enough dir info, and returns NULL if there is enough. Maybe instead the function could be named something like entry_guards_get_err_str_if_dir_info_missing() ?

comment:7 Changed 12 months ago by nickm

Status: needs_reviewneeds_revision

comment:8 Changed 12 months ago by asn

Status: needs_revisionneeds_review

Pushed two new commits addressing both comments above.

comment:9 Changed 12 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Looks good! Testing and merging.

Note: See TracTickets for help on using tickets.