Say how many primary entry guards we're missing descriptors for

Let's say:

We're missing descriptors for %d/%d of our primary entry guards

That would be a more helpful diagnostic for #21969 (moved).

changed milestone to %Tor: 0.3.2.x-final

added component::core tor/tor milestone::Tor: 0.3.2.x-final owner::asn parent::21969 points::0.5 priority::medium resolution::implemented severity::normal status::closed tor-bridge tor-client tor-guard type::enhancement labels

+1

Trac:
Owner: N/A to asn
Status: new to assigned

Please see branch !bug23670 in my repo for the feature and a basic unittest.

Trac:
Status: assigned to needs_review

Pushed two more commits implementing the #23671 (moved) feature as well, since they are very tightly coupled.

Trac:
Milestone: Tor: 0.3.3.x-final to Tor: 0.3.2.x-final

Two issues:

1. Changes file, please?
2. I think that the old function name name (entry_guards_have_enough_dir_info_to_build_circuits) was much more clear than (entry_guards_get_dir_info_status_str); it's not clear from the name of the new function that it checks whether there is enough dir info, and returns NULL if there is enough. Maybe instead the function could be named something like entry_guards_get_err_str_if_dir_info_missing() ?

Trac:
Status: needs_review to needs_revision

Pushed two new commits addressing both comments above.

Trac:
Status: needs_revision to needs_review

Looks good! Testing and merging.

Trac:
Resolution: N/A to implemented
Status: needs_review to closed

closed

changed time estimate to 4h

mentioned in issue #23671 (moved)

moved to tpo/core/tor#23670 (closed)