Tor kinda _is_ an http proxy now...

When we added HTTPTunnelPort, the answer that we give when you try to use your SOCKSPort as an HTTP proxy became wrong. We should fix it and explain that, Tor sorta is an HTTP proxy... but this port isn't.

changed milestone to %Tor: 0.3.2.x-final

added component::core tor/tor easy milestone::Tor: 0.3.2.x-final owner::nickm priority::medium resolution::fixed severity::normal status::closed tor-doc type::defect ux labels

(If anybody wants to fix this up, the string to revise is SOCKS_PROXY_IS_NOT_AN_HTTP_PROXY_MSG in proto_socks.c)

Trac:
Keywords: N/A deleted, easy tor-doc ux added

Trac:
Owner: N/A to nickm
Status: new to accepted

bug23678_032 has a straightforward fix.

Trac:
Status: accepted to needs_review

Mostly looks good!

The test suite needs updating to expect the revised message:

  FAIL src/test/test_socks.c:766: expected log to contain "Socks version 71 not recognized. " "(Tor is not an http proxy.)"  Captured logs:
    1. warn: "Socks version 71 not recognized. (This port is not an HTTP proxy; did you want to use HTTPTunnelPort?)\n"

Trac:
Status: needs_review to needs_revision

Thanks! Fixed that (with f923aeee1b14c2f64a657049ba46e68d70f53a0f) and merged the branch.

Trac:
Status: needs_revision to closed
Resolution: N/A to fixed

closed

moved to tpo/core/tor#23678 (closed)