Opened 2 years ago

Closed 2 years ago

#23678 closed defect (fixed)

Tor kinda _is_ an http proxy now...

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy tor-doc ux
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When we added HTTPTunnelPort, the answer that we give when you try to use your SOCKSPort as an HTTP proxy became wrong. We should fix it and explain that, Tor sorta _is_ an HTTP proxy... but this port isn't.

Child Tickets

Change History (6)

comment:1 Changed 2 years ago by nickm

(If anybody wants to fix this up, the string to revise is SOCKS_PROXY_IS_NOT_AN_HTTP_PROXY_MSG in proto_socks.c)

comment:2 Changed 2 years ago by catalyst

Keywords: easy tor-doc ux added

comment:3 Changed 2 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:4 Changed 2 years ago by nickm

Status: acceptedneeds_review

bug23678_032 has a straightforward fix.

comment:5 Changed 2 years ago by catalyst

Status: needs_reviewneeds_revision

Mostly looks good!

The test suite needs updating to expect the revised message:

  FAIL src/test/test_socks.c:766: expected log to contain "Socks version 71 not recognized. " "(Tor is not an http proxy.)"  Captured logs:
    1. warn: "Socks version 71 not recognized. (This port is not an HTTP proxy; did you want to use HTTPTunnelPort?)\n"

comment:6 Changed 2 years ago by nickm

Resolution: fixed
Status: needs_revisionclosed

Thanks! Fixed that (with f923aeee1b14c2f64a657049ba46e68d70f53a0f) and merged the branch.

Note: See TracTickets for help on using tickets.