Opened 10 months ago

Last modified 6 months ago

#23713 assigned enhancement

Add as_name parameter

Reported by: cypherpunks Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Currently one can search for relays in a specific AS with the as parameter,
but you can not search for all relays with a given as_name (big organizations have multiple ASes).

I'd like to make the entries in this table clickable atlas URLs

Note: as_names usually contain spaces

Child Tickets

Change History (3)

comment:1 Changed 9 months ago by karsten

Owner: changed from metrics-team to karsten
Status: newaccepted

Sounds useful to me. We should probably implement #21366 first to fully support AS names containing spaces. But other than that I don't see any major problems.

For the sake of consistency between field names and parameter names we might consider renaming the "as_number" field to just "as". That's also more consistent with "country" for the country code and "country_name" for the country name. This change would require a major version bump, but in this case we could easily include both fields for a few months until clients are updated. So, adding an "as" field would be the minor protocol change and removing the "as_number" field would be the major protocol change. Or maybe the latter would also be a minor change, because the field is optional. Anyway, something to consider and somewhat related to this feature request.

comment:2 Changed 9 months ago by irl

I think as and as_name are both fine, the _number does look redundant to me.

nusenu: I would encourage you though, to consider making the URLs link to as:X as this would be a more accurate search, especially as AS names would have to be a partial string search to be useful to end users. e.g. I might search for OVH instead of "OVH SAS". Exact string searches would only be useful to applications that probably have the AS number already.

comment:3 Changed 6 months ago by karsten

Owner: changed from karsten to metrics-team
Status: acceptedassigned

This still seems like a worthwhile enhancement, but I'm not going to find the time to do it anytime soon. Re-assigning to metrics-team for now.

Note: See TracTickets for help on using tickets.