Opened 3 years ago

Last modified 3 years ago

#23720 new defect

'make test' writes into my /tmp

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


I check out Tor from the git repo, and build it with autogen, configure, etc.

Then I run 'make test', from the git repo directory. I ctrl-C it partway through.

To my surprise, now there is a new directory in /tmp:

drwx------  2 arma arma 4096 Oct  1 02:08 /tmp/tor_test_4360_xa6h7e6i

I noticed this because I found earlier tor_test directories in /tmp too, from days or weeks ago.

Shouldn't tor be using its own tempdir somewhere? I mean, it's nice that it tries to clean up after itself, but it does not succeed all the time. Maybe putting the files somewhere else, which doesn't get deleted at reboot, could be worse because then nothing would clean them up. Or maybe putting them somewhere in this directory tree would let 'make clean' be able to handle them?

Feel free to close with "we thought this through, and decided that littering in /tmp was our best option". But maybe there is a better one? :)

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by Sebastian

/tmp seems like the appropriate place to me

comment:2 Changed 3 years ago by dgoulet

Prefixing a "tor" temporary directory in /tmp is something standard in my experience. It could be more of a problem if we were doing something like /tmp/test/ but prefixing with tor_test_... seems right to me.

comment:3 Changed 3 years ago by dgoulet

Milestone: Tor: unspecified
Note: See TracTickets for help on using tickets.