Opened 14 months ago

Closed 13 months ago

Last modified 13 months ago

#23724 closed defect (fixed)

NoScript restartless update breaks Security Slider and its icon disappears

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Critical Keywords: noscript, TorBrowserTeam201710
Cc: ma1, arthuredelstein, Dbryrtfbcbhgf Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We have reports that the NoScript update to 5.1.1 broke the Security Slider for users and the NoScript icon disappears.

Child Tickets

Change History (39)

comment:1 Changed 14 months ago by gk

This might be related to #23723 but that is unclear right now.

Repeating my comment:12:ticket:23718 here:

I tested updating Noscript to 5.1.1 both in Tor Browser 7.0.6 and 7.5a5 and while I saw the same error in the browser console I kept a working NoScript and the security slider was not messed up as comment:16 reports (and other users, too, on IRC). Thus, we have at least one additional bug that is causing this or could that somehow be a result of Tor Browser breaking the entity resolution? If so, how can I reproduce this?

I followed the steps in comment:22:ticket:23718 but could not reproduce it because a restart is required.

I wonder if that only happend when updating from a version with the new NoScript code to a newer one, like it happened from 5.1.0 to 5.1.1 while the problem is not visible when updating from the old code (e.g. 5.0.10) to 5.1.1 directly.

FWIW: it got reported that a restart gives functionality back (although the icon seems still to be replaced, now it's showing up on the right side next to the hamburger menu).

comment:2 Changed 14 months ago by cypherpunks

I wonder if that only happend when updating from a version with the new NoScript code to a newer one, like it happened from 5.1.0 to 5.1.1 while the problem is not visible when updating from the old code (e.g. 5.0.10) to 5.1.1 directly.

I bet it's that since from the NoScript changelog,

5.1.x is the first restartless NoScript desktop version

comment:3 Changed 14 months ago by cypherpunks

Keywords: noscript added
Severity: MajorCritical
Summary: NoScript update breaks Security Slider and its icon disappearsNoScript restartless update breaks Security Slider and its icon disappears

I wonder if that only happend when updating from a version with the new NoScript code to a newer one, like it happened from 5.1.0 to 5.1.1 while the problem is not visible when updating from the old code (e.g. 5.0.10) to 5.1.1 directly.

comment 23 is the answer, 22 is by another cpunk. NoScript resets to its defaults, not TBB's!

comment:4 in reply to:  3 Changed 14 months ago by gk

Replying to cypherpunks:

I wonder if that only happend when updating from a version with the new NoScript code to a newer one, like it happened from 5.1.0 to 5.1.1 while the problem is not visible when updating from the old code (e.g. 5.0.10) to 5.1.1 directly.

comment 23 is the answer, 22 is by another cpunk. NoScript resets to its defaults, not TBB's!

Yes. This results in e.g.

TypeError: ABE is undefined[Weitere Informationen]  ABE.js:1198:21
TypeError: WAN is undefined[Weitere Informationen]  ABE.js:1186:23

ma1: I just reproduced this with a clean new profile in a vanilla Firefox 52 ESR. This is no Tor Browser issue. Could you please look at that one before pushing a new NoScript update? Here are my steps to reproduce:

1) Create a new profile to be used with a Firefox 52 ESR
2) Copy a NoScript 5.0.10 into the extensions directory and start the browser with the new profile
3) NoScript should be ready, close the browser if so
4) Copy NoScript 5.1.0 over 5.0.10 and create a preferences folder in the profile directory + customize NoScript by copying https://gitweb.torproject.org/builders/tor-browser-bundle.git/tree/Bundle-Data/linux/Data/Browser/profile.default/preferences/extension-overrides.js into it. That just flips some NoScript defaults
5) Restart and make sure it is working
6) Now, update to NoScript 5.1.1 (via the in-browser extension update means)
7) NoScript's prefs are reset and the errors in the browser console pop up
8) After restart it seems NoScript is working again as expected.

comment:5 Changed 14 months ago by arthuredelstein

Cc: arthuredelstein added

comment:6 Changed 14 months ago by cypherpunks

This madness was reported for 5.1rc2, but it was released untested! See https://forums.informaction.com/viewtopic.php?f=7&t=23333

After restart NoScript resets to TBB's defaults (Low), ignoring the Security Slider settings.

comment:7 Changed 14 months ago by cypherpunks

[10-04 08:01:29] Torbutton WARN: New Identity: Error clearing NoScript Temporary Permissions: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: chrome://torbutton/content/torbutton.js :: torbutton_do_new_identity :: line 1058"  data: no]

comment:8 Changed 14 months ago by cypherpunks

On Win 10 TBB 7.5a5 updates itself to 5.1.0 (why?) and icon doesn't appear after restart.
Also

1507179043900	addons.xpi	WARN	Exception running bootstrap method shutdown on {73a6fe31-595d-460b-a920-fcc0f8843232}: TypeError: module.shutdown is not a function (resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Tor%20Browser/Browser/TorBrowser/Data/Browser/profile.default/extensions/%7B73a6fe31-595d-460b-a920-fcc0f8843232%7D.xpi!/bootstrap.js:30:5) JS Stack trace: shutdown@bootstrap.js:30:5 < this.XPIProvider.callBootstrapMethod@XPIProvider.jsm:5041:9 < startInstall/<@XPIProvider.jsm:5932:15

Seems NoScript conflicts with other add-ons (calls their chrome.manifest), fails to move its file to /trash and so on...

comment:9 Changed 14 months ago by gk

Cc: Dbryrtfbcbhgf added

#23776 is a duplicate.

comment:10 Changed 14 months ago by ma1

Just released rc2, which should partially fix this: preference overrides by Tor Browser (or any .js file in $PROFD/preferences/, for the matter) are honored now, per comment:4.

I'm not sure this suffices, since some of the stuff showing up in the console seems (e.g. in comment:7) due to the Tor customization machinery not expecting NoScript to be updated / disabled / re-enabled on the fly, and therefore references to objects from the previous instance becoming invalid.

comment:11 Changed 14 months ago by cypherpunks

Status: newneeds_information

Icon jumps to the right.

1507347423800	addons.xpi	DEBUG	Starting install of {73a6fe31-595d-460b-a920-fcc0f8843232} from https://addons.mozilla.org/firefox/downloads/latest-beta/noscript/addon-722-latest.xpi?src=ss
1507347423900	addons.xpi	DEBUG	Addon {73a6fe31-595d-460b-a920-fcc0f8843232} will be installed as a packed xpi
CustomizableUI:Widget 'noscript-tbb' not found, unable to move  CustomizableUI.jsm:1149

You start updating with removal of the tbb, and it has different id, correct?

1507347424100	addons.xpi	DEBUG	Calling bootstrap method shutdown on {73a6fe31-595d-460b-a920-fcc0f8843232} version 5.1.1
can't access dead object  WebExt.js:17

What are you trying to 'tell' here?

1507347424200	addons.xpi	DEBUG	Removing manifest for C:\Tor Browser\Browser\TorBrowser\Data\Browser\profile.default\extensions\{73a6fe31-595d-460b-a920-fcc0f8843232}.xpi
Bootstrapped manifest not allowed to use 'component' directive.  chrome.manifest:60

Why does it call HTTPS-Everywhere's chrome.manifest?

1507347424500	addons.xpi	DEBUG	Install of https://addons.mozilla.org/firefox/downloads/latest-beta/noscript/addon-722-latest.xpi?src=ss completed.
No chrome package registered for chrome://noscript/locale/about.properties
1507347424600	addons.xpi	DEBUG	Registering manifest for C:\Tor Browser\Browser\TorBrowser\Data\Browser\profile.default\extensions\{73a6fe31-595d-460b-a920-fcc0f8843232}.xpi

Firefox wants better code.

1507347424600	addons.xpi	DEBUG	Calling bootstrap method startup on {73a6fe31-595d-460b-a920-fcc0f8843232} version 5.1.2rc2
TypeError: ABE is undefined[Learn More]  ABE.js:1198:21
TypeError: WAN is undefined[Learn More]  ABE.js:1186:23

Heh.

No matching message handler for the given recipient.  MessageChannel.jsm:621
Torbutton NOTE: Failed to update NoScript status for security setings: TypeError: win.noscriptOverlay is undefined
1507347425700	addons.webextension.{73a6fe31-595d-460b-a920-fcc0f8843232}	WARN	Loading extension '{73a6fe31-595d-460b-a920-fcc0f8843232}': Reading manifest: Error processing permissions.1: Unknown permission "privacy"
TypeError: Date is undefined[Learn More]  ClearClickHandler.js:318:9

So we have a short period of time with broken settings, and then

Torbutton INFO: Updated NoScript status for security settings

But why do we have ClearClick checkbox still selected?

comment:12 in reply to:  10 Changed 14 months ago by gk

Replying to ma1:

Just released rc2, which should partially fix this: preference overrides by Tor Browser (or any .js file in $PROFD/preferences/, for the matter) are honored now, per comment:4.

I'm not sure this suffices, since some of the stuff showing up in the console seems (e.g. in comment:7) due to the Tor customization machinery not expecting NoScript to be updated / disabled / re-enabled on the fly, and therefore references to objects from the previous instance becoming invalid.

I see. I think if it's just that single issue that is still unsolved that's okay for now and we can try to fix that on our side. But it seems there still remain more things that are worrisome, see comment:11. For instance, we don't have ABE enabled and it seems there should not be any errors in the console regarding it. Furthermore, the icon should not jump to the right either I think. AFAICT that's not due to any interfering Torbutton/Tor Browser code and I was able to reproduce that in a clean Firefox 52ESR as well as outlined in comment:4.

(Note: I have not tested rc2 yet but just assumed that the issues the cypherpunk mentioned in comment:11 are indeed showing up when updating to rc2)

comment:13 in reply to:  10 Changed 14 months ago by gk

Status: needs_informationneeds_revision

Replying to ma1:

Just released rc2, which should partially fix this: preference overrides by Tor Browser (or any .js file in $PROFD/preferences/, for the matter) are honored now, per comment:4.

Okay, I followed my steps in a clean, new Firefox 52 ESR (just using 5.1.2rc1 and updating it to 5.1.2rc2). It seems the preferences are indeed honored, thanks. But there are still concerning things in the browser console visible:

No chrome package registered for chrome://noscript/locale/about.properties
TypeError: ABE is undefined  ABE.js:1198:21
TypeError: WAN is undefined  ABE.js:1186:23
TypeError: ABE is undefined  ABE.js:1198:21
TypeError: WAN is undefined  ABE.js:1186:23
TypeError: Ci is undefined  Main.js:138:1
TypeError: Date is undefined  ClearClickHandler.js:318:9

Those errors go away after a restart of the browser, though. If you look at the prefs file in comment:4 there are no special Tor Browser related ones in it. It's just NoScript configuration (disabling ABE etc.).

comment:14 Changed 14 months ago by gk

With a clean Tor Browser, replacing the NoScript version we ship with 5.1.2rc1 before starting it with the first time works as expected, however the update results in the errors mentioned in comment:13 plus I see:

CustomizableUI:Widget 'noscript-tbb' not found, unable to move  CustomizableUI.jsm:1149

and the icon jumping to the right. On subsequent restarts I get

[Exception... "Failure"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://noscript/content/Restartless.jsm?0.8314032359350465.1507411166800 :: loadIntoWindow :: line 193"  data: no]  (unknown)
Could not overlay chrome://browser/content/browser.xul  Restartless.jsm:224

.

comment:15 Changed 14 months ago by gk

Actually, I already see

noscript-tbb not found!
[Exception... "Failure"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://noscript/content/Restartless.jsm?0.5651077320914104.1507411556800 :: loadIntoWindow :: line 166"  data: no]  (unknown)
Could not overlay chrome://browser/content/browser.xul  Restartless.jsm:197

before doing the update to 5.1.2rc2 just by copying 5.1.2rc1 over 5.0.10 before even starting the browser once. Interstingly, the icon is still on the left side as it should be in that case. It only moves to the right side next to the search bar with the update.

comment:16 Changed 14 months ago by ma1

Please check https://addons.mozilla.org/en-US/firefox/addon/noscript/versions/5.1.2rc3

Notice that the HTTPS Everywhere manifest thing is unrelated to NoScript specifically (but maybe triggered by the restartless upgrade routine).

comment:17 in reply to:  11 Changed 14 months ago by cypherpunks

Replying to cypherpunks:
ma1 keeps silence, so updating for rc3:

Icon jumps to the right.

No jumping, but already broken TBB installations need a fixup.

1507347423800	addons.xpi	DEBUG	Starting install of {73a6fe31-595d-460b-a920-fcc0f8843232} from https://addons.mozilla.org/firefox/downloads/latest-beta/noscript/addon-722-latest.xpi?src=ss
1507347423900	addons.xpi	DEBUG	Addon {73a6fe31-595d-460b-a920-fcc0f8843232} will be installed as a packed xpi
CustomizableUI:Widget 'noscript-tbb' not found, unable to move  CustomizableUI.jsm:1149

You start updating with removal of the tbb, and it has different id, correct?

Patched.

1507347424100	addons.xpi	DEBUG	Calling bootstrap method shutdown on {73a6fe31-595d-460b-a920-fcc0f8843232} version 5.1.1
can't access dead object  WebExt.js:17

What are you trying to 'tell' here?

Still trying...

1507347424200	addons.xpi	DEBUG	Removing manifest for C:\Tor Browser\Browser\TorBrowser\Data\Browser\profile.default\extensions\{73a6fe31-595d-460b-a920-fcc0f8843232}.xpi
Bootstrapped manifest not allowed to use 'component' directive.  chrome.manifest:60

Why does it call HTTPS-Everywhere's chrome.manifest?

You say Firefox re-registering manifests after removal of one, right?

1507347424500	addons.xpi	DEBUG	Install of https://addons.mozilla.org/firefox/downloads/latest-beta/noscript/addon-722-latest.xpi?src=ss completed.
No chrome package registered for chrome://noscript/locale/about.properties
1507347424600	addons.xpi	DEBUG	Registering manifest for C:\Tor Browser\Browser\TorBrowser\Data\Browser\profile.default\extensions\{73a6fe31-595d-460b-a920-fcc0f8843232}.xpi

Firefox wants better code.

It wants registering addon first.

No chrome package registered for chrome://noscript/skin/icon32.png
1507347424600	addons.xpi	DEBUG	Calling bootstrap method startup on {73a6fe31-595d-460b-a920-fcc0f8843232} version 5.1.2rc2
TypeError: ABE is undefined[Learn More]  ABE.js:1198:21
TypeError: WAN is undefined[Learn More]  ABE.js:1186:23

Heh.

Patched.

No matching message handler for the given recipient.  MessageChannel.jsm:621
Torbutton NOTE: Failed to update NoScript status for security setings: TypeError: win.noscriptOverlay is undefined
1507347425700	addons.webextension.{73a6fe31-595d-460b-a920-fcc0f8843232}	WARN	Loading extension '{73a6fe31-595d-460b-a920-fcc0f8843232}': Reading manifest: Error processing permissions.1: Unknown permission "privacy"

So we have a short period of time with broken settings, and then

It's enough to break the Security Slider.

Torbutton INFO: Updated NoScript status for security settings

But why do we have ClearClick checkbox still selected?

Patched.
But why doesn't it honor Forbid A/V settings?

Unrelated issues:

06:51:47.366 TypeError: Cu is undefined 1 PasteHandler.jsm:16:3

Misc.

10:05:32.529 about:blank : Unable to run script because scripts are blocked internally. 1 (unknown)

Why does NoScript try to do that?

gk:

13:53:06.588 NoScript could not disable scripts for system global [System Principal] 1 WinScript.js:13:11

See ticket:20752#comment:2:

BTW, does the Tor Browser have its own customized mandatory whitelist? If so, you should add [System+Principal] (yes, with the "+" instead of " "), which is in NoScript's default and should fix half of the cases.

02:05:11.786 TypeError: overlayQueue is undefined 1 Restartless.jsm:134:5

Torbutton misses NoScript...

comment:18 in reply to:  16 ; Changed 14 months ago by gk

Replying to ma1:

Please check https://addons.mozilla.org/en-US/firefox/addon/noscript/versions/5.1.2rc3

Notice that the HTTPS Everywhere manifest thing is unrelated to NoScript specifically (but maybe triggered by the restartless upgrade routine).

This looks better, thanks. But I still get:

TypeError: ABE is undefined[Learn More]  ABE.js:1198:21
TypeError: WAN is undefined[Learn More]  ABE.js:1186:23
TypeError: ABE is undefined[Learn More]  ABE.js:1198:21
TypeError: WAN is undefined[Learn More]  ABE.js:1186:23
No matching message handler for the given recipient.  MessageChannel.jsm:621

in the browser console.

And the icon is still jumping to the right. Any idea why this one in particular is happening?

comment:19 in reply to:  18 ; Changed 14 months ago by ma1

Replying to gk:

This looks better, thanks. But I still get:

TypeError: ABE is undefined[Learn More]  ABE.js:1198:21
TypeError: WAN is undefined[Learn More]  ABE.js:1186:23
TypeError: ABE is undefined[Learn More]  ABE.js:1198:21
TypeError: WAN is undefined[Learn More]  ABE.js:1186:23
No matching message handler for the given recipient.  MessageChannel.jsm:621

in the browser console.

If you're installing over a previous restartless version (5.1.x) that's normal, noisy but no side effect, and nothing we can't do about it because those messages are from the previous instance. It shouldn't happen for new installations and/or upgrading / disabling+enabling over 5.1.2rc3 and above.

And the icon is still jumping to the right. Any idea why this one in particular is happening?

Again, if the icon has already "jumped" on the right there's nothing to do about it, because you cannot tell whether it happened because of a previous restartless version or becuase the user customized the position manually.

However it should not change the icon position from where it's found initially (e.g. if you install on a fresh Tor Browser it should stay on the left).

comment:20 in reply to:  19 ; Changed 14 months ago by gk

Replying to ma1:

Replying to gk:

This looks better, thanks. But I still get:

TypeError: ABE is undefined[Learn More]  ABE.js:1198:21
TypeError: WAN is undefined[Learn More]  ABE.js:1186:23
TypeError: ABE is undefined[Learn More]  ABE.js:1198:21
TypeError: WAN is undefined[Learn More]  ABE.js:1186:23
No matching message handler for the given recipient.  MessageChannel.jsm:621

in the browser console.

If you're installing over a previous restartless version (5.1.x) that's normal, noisy but no side effect, and nothing we can't do about it because those messages are from the previous instance. It shouldn't happen for new installations and/or upgrading / disabling+enabling over 5.1.2rc3 and above.

Okay.

And the icon is still jumping to the right. Any idea why this one in particular is happening?

Again, if the icon has already "jumped" on the right there's nothing to do about it, because you cannot tell whether it happened because of a previous restartless version or becuase the user customized the position manually.

However it should not change the icon position from where it's found initially (e.g. if you install on a fresh Tor Browser it should stay on the left).

But that's what I did:

1) Extract a clean Tor Browser 7.5a5
2) Copy NoScript 5.1.2rc2 over the NoScript we ship
3) Start the browser, the icon is on the left side
4) Check for NoScript updates and 5.1.2r3 gets installed and the icon jumps to the right

We have a bunch of

[10-09 15:36:27] Torbutton NOTE: Failed to update NoScript status for security setings: TypeError: win.noscriptOverlay is undefined

errors in the console as we call its _syncUINOw() once a NoScript pref gets changed (and that happens with the update apparently). But that does not seems to be a candidate for causing this issue to me. Hm.

comment:21 in reply to:  20 ; Changed 14 months ago by ma1

Replying to gk:

1) Extract a clean Tor Browser 7.5a5
2) Copy NoScript 5.1.2rc2 over the NoScript we ship
3) Start the browser, the icon is on the left side
4) Check for NoScript updates and 5.1.2r3 gets installed and the icon jumps to the right

I suppose you're doing this, rather than updating directly from a non-restartless version (like the ones you currently ship) to check whether updating restartless to restartless makes the icon jump nevertheless. However, since rc2 interferes with the previous icon placement in a way rc3 doesn't, whether the effect is visible or not, I'd rather try to update from rc3 to rc4 (about to be released) to tell if the bug needs more work or not.

We have a bunch of

[10-09 15:36:27] Torbutton NOTE: Failed to update NoScript status for security setings: TypeError: win.noscriptOverlay is undefined

errors in the console as we call its _syncUINOw() once a NoScript pref gets changed (and that happens with the update apparently). But that does not seems to be a candidate for causing this issue to me. Hm

I don't think it's a real problem, console noise aside, but if you want it to be fixed anyway you must do it on your side: on initialization NoScript might cause preference observers to be called at a moment when noscriptOverlay does not exist yet: this means you must check for win.noscriptOverlay existence before referencing it.

comment:22 Changed 14 months ago by cypherpunks

On subsequent restarts I get

noscript-tbb not found!	
16:21:03.598 [Exception... "Failure"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://noscript/content/Restartless.jsm?0.5651077320914104.1507411556800 :: loadIntoWindow :: line 193"  data: no] 1 (unknown)	
	loadIntoWindow chrome://noscript/content/Restartless.jsm:193:5
	observe chrome://noscript/content/Restartless.jsm:218:11
16:21:03.599 Could not overlay chrome://browser/content/browser.xul 1 Restartless.jsm:224	
	loadIntoWindow chrome://noscript/content/Restartless.jsm:224:5
	observe chrome://noscript/content/Restartless.jsm:218:11
[10-10 16:21:04] Torbutton INFO: New window

because you try to do that before first window is created.

Also this

Also don't ignore this

It's better to release this with ESR52.4.1 in order to include into the next TBB update.

gk:

15:29:21.053 Unchecked lastError value: Error: Invalid tab ID: 194 1 ExtensionCommon.jsm:265	
	withLastError resource://gre/modules/ExtensionCommon.jsm:265:9
	wrapPromise/< resource://gre/modules/ExtensionCommon.jsm:316:11
	torbutton_send_ctrl_cmd chrome://torbutton/content/torbutton.js:868:10
	torbutton_do_new_identity chrome://torbutton/content/torbutton.js:1223:10
	torbutton_new_identity chrome://torbutton/content/torbutton.js:961:9
	oncommand chrome://browser/content/browser.xul:1:1

comment:23 in reply to:  21 Changed 14 months ago by gk

Replying to ma1:

Replying to gk:

1) Extract a clean Tor Browser 7.5a5
2) Copy NoScript 5.1.2rc2 over the NoScript we ship
3) Start the browser, the icon is on the left side
4) Check for NoScript updates and 5.1.2r3 gets installed and the icon jumps to the right

I suppose you're doing this, rather than updating directly from a non-restartless version (like the ones you currently ship) to check whether updating restartless to restartless makes the icon jump nevertheless. However, since rc2 interferes with the previous icon placement in a way rc3 doesn't, whether the effect is visible or not, I'd rather try to update from rc3 to rc4 (about to be released) to tell if the bug needs more work or not.

Sounds good and, yes, that what was my intention behind the testing.

We have a bunch of

[10-09 15:36:27] Torbutton NOTE: Failed to update NoScript status for security setings: TypeError: win.noscriptOverlay is undefined

errors in the console as we call its _syncUINOw() once a NoScript pref gets changed (and that happens with the update apparently). But that does not seems to be a candidate for causing this issue to me. Hm

I don't think it's a real problem, console noise aside, but if you want it to be fixed anyway you must do it on your side: on initialization NoScript might cause preference observers to be called at a moment when noscriptOverlay does not exist yet: this means you must check for win.noscriptOverlay existence before referencing it.

Sure. I was just mentioning it as the other thing I saw on the browser console.

comment:24 Changed 14 months ago by ma1

5.1.2rc4is out, is everything looks good I'm gonna turn it into a release ASAP.

comment:25 Changed 14 months ago by cypherpunks

It seems Giorgio doesn't talk with anonymous :)
But, nevertheless, let's summarize the results of rc4:

Clean install:

No chrome package registered for chrome://noscript/skin/icon32.png
1507707555800 addons.xpi WARN Failed to remove temporary file C:\Users\X\AppData\Local\Temp\tmp-04t.xpi for addon https://addons.mozilla.org/firefox/downloads/latest-beta/noscript/addon-722-latest.xpi?src=ss: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: removeTemporaryFile :: line 5598"  data: no] Stack trace: removeTemporaryFile()@resource://gre/modules/addons/XPIProvider.jsm:5598 < startInstall/<()@resource://gre/modules/addons/XPIProvider.jsm:6027 < Handler.prototype.process()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:932 < this.PromiseWalker.walkerLoop()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813 < this.PromiseWalker.scheduleWalkerLoop/<()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747
[10-11 07:39:15] Torbutton NOTE: Failed to update NoScript status for security setings: TypeError: win.noscriptOverlay is undefined
1507707556000 addons.webextension.{73a6fe31-595d-460b-a920-fcc0f8843232} WARN Loading extension '{73a6fe31-595d-460b-a920-fcc0f8843232}': Reading manifest: Error processing permissions.1: Unknown permission "privacy"

The first error (two similar, actually) leads to NoScript's two icons in Customize menu don't show. TBB doesn't use them, though.
gk: the second error is tbb-disk-leak.

Restartless update:

No chrome package registered for chrome://noscript/locale/about.properties
08:26:39.787 No matching message handler for the given recipient. 1 MessageChannel.jsm:621	
	_handleMessage/</< resource://gre/modules/MessageChannel.jsm:621:11

and comment:22.

Security Slider survived \o/

comment:26 in reply to:  25 ; Changed 14 months ago by ma1

Replying to cypherpunks:

It seems Giorgio doesn't talk with anonymous :)

A lot of scary stuff spit by the console is unrelated to NoScript specifically (may apply to any hybrid / restatless extension) and/or cannot be fixed "from the inside" of the add-on: case in point, from the browser being unable to delete temporary files or to register chrome packages at the right time.

No chrome package registered for chrome://noscript/locale/about.properties
08:26:39.787 No matching message handler for the given recipient. 1 MessageChannel.jsm:621        
_handleMessage/</< resource://gre/modules/MessageChannel.jsm:621:11

... or this, which might happen whenever any WebExtension is uninstalled / disabled if there were pending messages.

and comment:22.

This should be fixed (in most cases, at least) by rc5 (about to become a release) and was cosmetic anyway.

comment:27 in reply to:  26 ; Changed 14 months ago by cypherpunks

Replying to ma1:
Hi, Giorgio.
Unfortunately, not all issues with the Security Slider were resolved. The last one is that NoScript preferences backup on the WebExtension side doesn't happen right after updating NoScript settings by the Torbutton. This has weird effects, e.g. videos play automatically on Low, but under the rectangle of blocked video, and NoScript icon and menu show that the video was blocked (left from the previously selected Medium level).

A lot of scary stuff spit by the console is unrelated to NoScript specifically (may apply to any hybrid / restatless extension) and/or cannot be fixed "from the inside" of the add-on: case in point, from the browser being unable to delete temporary files

17:21:54.970 1507742514900	addons.xpi	ERROR	Failed to remove file C:\Tor Browser\Browser\TorBrowser\Data\Browser\profile.default\extensions\trash\{73a6fe31-595d-460b-a920-fcc0f8843232}.xpi: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: recursiveRemove :: line 2005"  data: no] Stack trace: recursiveRemove()@resource://gre/modules/addons/XPIProvider.jsm:2005 < recursiveRemove()@resource://gre/modules/addons/XPIProvider.jsm:2020 < .installAddon()@resource://gre/modules/addons/XPIProvider.jsm:8600 < startInstall/<()@resource://gre/modules/addons/XPIProvider.jsm:5951 < TaskImpl_run()@resource://gre/modules/Task.jsm:319 < Handler.prototype.process()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:932 < this.PromiseWalker.walkerLoop()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813 < this.PromiseWalker.scheduleWalkerLoop/<()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747 1 Log.jsm:753
	App_append resource://gre/modules/Log.jsm:753:9		
	Logger.prototype.log resource://gre/modules/Log.jsm:389:7		
	Logger.prototype.error resource://gre/modules/Log.jsm:397:5		
	recursiveRemove resource://gre/modules/addons/XPIProvider.jsm:2010:7		
	forEach self-hosted:251:13		
	recursiveRemove resource://gre/modules/addons/XPIProvider.jsm:2020:3		
	.installAddon resource://gre/modules/addons/XPIProvider.jsm:8600:9		
	startInstall/< resource://gre/modules/addons/XPIProvider.jsm:5951:20		
	next self-hosted:1120:9		
	TaskImpl_run resource://gre/modules/Task.jsm:319:42		
	bound TaskImpl_run self-hosted:957:17		
	Handler.prototype.process resource://gre/modules/Promise-backend.js:932:23		
	this.PromiseWalker.walkerLoop resource://gre/modules/Promise-backend.js:813:7		
	bound  self-hosted:913:17		
	bound bound  self-hosted:913:17		
	this.PromiseWalker.scheduleWalkerLoop/< resource://gre/modules/Promise-backend.js:747:11		
1507742514900	addons.xpi	WARN	Failed to remove trash directory when installing {73a6fe31-595d-460b-a920-fcc0f8843232}: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: recursiveRemove :: line 2005"  data: no] Stack trace: recursiveRemove()@resource://gre/modules/addons/XPIProvider.jsm:2005 < recursiveRemove()@resource://gre/modules/addons/XPIProvider.jsm:2020 < .installAddon()@resource://gre/modules/addons/XPIProvider.jsm:8600 < startInstall/<()@resource://gre/modules/addons/XPIProvider.jsm:5951 < TaskImpl_run()@resource://gre/modules/Task.jsm:319 < Handler.prototype.process()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:932 < this.PromiseWalker.walkerLoop()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813 < this.PromiseWalker.scheduleWalkerLoop/<()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747

This is an ERROR exactly and should be fixed.

or to register chrome packages at the right time.

Addons should wait until manifest is registered by Firefox. This is critical.

No chrome package registered for chrome://noscript/locale/about.properties
08:26:39.787 No matching message handler for the given recipient. 1 MessageChannel.jsm:621        
_handleMessage/</< resource://gre/modules/MessageChannel.jsm:621:11

... or this, which might happen whenever any WebExtension is uninstalled / disabled if there were pending messages.

1507747660900	addons.xpi	DEBUG	Calling bootstrap method startup on {73a6fe31-595d-460b-a920-fcc0f8843232} version 5.1.2rc5
1507747661000	DeferredSave.extensions.json	DEBUG	Starting timer
1507747661000	addons.xpi	DEBUG	removeTemporaryFile: https://addons.mozilla.org/firefox/downloads/latest-beta/noscript/addon-722-latest.xpi?src=search removing temp file C:\Users\X\AppData\Local\Temp\tmp-2sv.xpi
No matching message handler for the given recipient.  MessageChannel.jsm:621

So, this happens in exact place during addon's startup.

and comment:22.

This should be fixed (in most cases, at least) by rc5 (about to become a release) and was cosmetic anyway.

Now we have

1507740751000	addons.webextension.<unknown>	WARN	Loading extension 'null': Reading manifest: Error processing permissions.1: Unknown permission "privacy"
1507740751000	addons.webextension.<unknown>	WARN	Loading extension 'null': Reading manifest: Error processing permissions.4: Unknown permission "unlimitedStorage"
1507740751800	addons.webextension.{73a6fe31-595d-460b-a920-fcc0f8843232}	WARN	Loading extension '{73a6fe31-595d-460b-a920-fcc0f8843232}': Reading manifest: Error processing permissions.1: Unknown permission "privacy"
1507740751800	addons.webextension.{73a6fe31-595d-460b-a920-fcc0f8843232}	WARN	Loading extension '{73a6fe31-595d-460b-a920-fcc0f8843232}': Reading manifest: Error processing permissions.4: Unknown permission "unlimitedStorage"

and

noscript-tbb not found!
[10-11 17:02:22] Torbutton INFO: New window

which is an exclamation about the obvious thing :)

As for comment:22, the links point to the tickets with annoying issues with functionality, not only cosmetic ones.
Update: it seems [System+Principal] doesn't work.

Last edited 14 months ago by cypherpunks (previous) (diff)

comment:28 in reply to:  27 ; Changed 14 months ago by ma1

Replying to cypherpunks:

Replying to ma1:
Hi, Giorgio.
Unfortunately, not all issues with the Security Slider were resolved. The last one is that NoScript preferences backup on the WebExtension side doesn't happen right after updating NoScript settings by the Torbutton.

It does on startup, shutdown and every type the NoScript Service's savePrefs() method is called.

It's meant to just backup the configuration, and should have no visible impact on how NoScript 5.x actually behaves. So, no "weird effects" from this are plausible.

This has weird effects, e.g. videos play automatically on Low, but under the rectangle of blocked video, and NoScript icon and menu show that the video was blocked (left from the previously selected Medium level).

See above. Please file a separate bug if you can consistently reproduce.

17:21:54.970 1507742514900        addons.xpi        ERROR        Failed to remove file C:\Tor Browser\Browser\TorBrowser\Data\Browser\profile.default\extensions\trash\{73a6fe31-595d-460b-a920-fcc0f8843232}.xpi: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: recursiveRemove :: line 2005"  data: no] ![...]
This is an `ERROR` exactly and should be fixed.

If you think it actually is, you should file a bug in Mozilla's Bugzilla tracker, Toolkit>Add-ons Manager component.

Addons should wait until manifest is registered by Firefox. This is critical.

Or, it might just be something not expecting NoScript to be uninstalled without a browser restart. Can you point out actual user-affecting issues directly caused by to this? If so, please file separate bugs.

1507747660900 addons.xpi DEBUG Calling bootstrap method startup on {73a6fe31-595d-460b-a920-fcc0f8843232} version 5.1.2rc5
1507747661000 DeferredSave.extensions.json DEBUG Starting timer
1507747661000 addons.xpi DEBUG removeTemporaryFile: https://addons.mozilla.org/firefox/downloads/latest-beta/noscript/addon-722-latest.xpi?src=search removing temp file C:\Users\X\AppData\Local\Temp\tmp-2sv.xpi
No matching message handler for the given recipient. MessageChannel.jsm:621
}}}
So, this happens in exact place during addon's startup.

"This" what?

Now we have

1507740751000        addons.webextension.<unknown>        WARN        Loading extension 'null': Reading manifest: Error processing permissions.1: Unknown permission "privacy"
1507740751000        addons.webextension.<unknown>        WARN        Loading extension 'null': Reading manifest: Error processing permissions.4: Unknown permission "unlimitedStorage"
1507740751800        addons.webextension.{73a6fe31-595d-460b-a920-fcc0f8843232}        WARN        Loading extension '{73a6fe31-595d-460b-a920-fcc0f8843232}': Reading manifest: Error processing permissions.1: Unknown permission "privacy"
1507740751800        addons.webextension.{73a6fe31-595d-460b-a920-fcc0f8843232}        WARN        Loading extension '{73a6fe31-595d-460b-a920-fcc0f8843232}': Reading manifest: Error processing permissions.4: Unknown permission "unlimitedStorage"

and

noscript-tbb not found!
[10-11 17:02:22] Torbutton INFO: New window

which is an exclamation about the obvious thing :)

... none of which is a bug, despite the exclamation mark.

Update: it seems [System+Principal] doesn't work.

Work at what? The message about [System Principal] just takes note that there was a window where scripts could not be blocked because it had chrome privileges. It's normal, and nothing that needs to be "fixed".

Suggestion: please set the "noscript.consoleDump" preference to 0. If anything actually abnormal happens, you'll get messages in the browser console anyway.

comment:29 in reply to:  28 ; Changed 14 months ago by cypherpunks

Replying to ma1:

Replying to cypherpunks:

Replying to ma1:
Hi, Giorgio.
Unfortunately, not all issues with the Security Slider were resolved. The last one is that NoScript preferences backup on the WebExtension side doesn't happen right after updating NoScript settings by the Torbutton.

It does on startup, shutdown and every type the NoScript Service's savePrefs() method is called.

It's meant to just backup the configuration, and should have no visible impact on how NoScript 5.x actually behaves. So, no "weird effects" from this are plausible.

This has weird effects, e.g. videos play automatically on Low, but under the rectangle of blocked video, and NoScript icon and menu show that the video was blocked (left from the previously selected Medium level).

See above. Please file a separate bug if you can consistently reproduce.

Hmm. Then it could be a restartless update issue (Set Security Slider to Medium before update).

17:21:54.970 1507742514900        addons.xpi        ERROR        Failed to remove file C:\Tor Browser\Browser\TorBrowser\Data\Browser\profile.default\extensions\trash\{73a6fe31-595d-460b-a920-fcc0f8843232}.xpi: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: recursiveRemove :: line 2005"  data: no] ![...]
This is an `ERROR` exactly and should be fixed.

If you think it actually is, you should file a bug in Mozilla's Bugzilla tracker, Toolkit>Add-ons Manager component.

Mozilla thinks. And we are not happy with a leftover in trash on disk.

Addons should wait until manifest is registered by Firefox. This is critical.

Or, it might just be something not expecting NoScript to be uninstalled without a browser restart. Can you point out actual user-affecting issues directly caused by to this? If so, please file separate bugs.

If random icon disappearing is not enough, then...

1507747660900 addons.xpi DEBUG Calling bootstrap method startup on {73a6fe31-595d-460b-a920-fcc0f8843232} version 5.1.2rc5
1507747661000 DeferredSave.extensions.json DEBUG Starting timer
1507747661000 addons.xpi DEBUG removeTemporaryFile: https://addons.mozilla.org/firefox/downloads/latest-beta/noscript/addon-722-latest.xpi?src=search removing temp file C:\Users\X\AppData\Local\Temp\tmp-2sv.xpi
No matching message handler for the given recipient. MessageChannel.jsm:621
}}}
So, this happens in exact place during addon's startup.

"This" what?

This error in MessageChannel.jsm

Now we have

1507740751000        addons.webextension.<unknown>        WARN        Loading extension 'null': Reading manifest: Error processing permissions.1: Unknown permission "privacy"
1507740751000        addons.webextension.<unknown>        WARN        Loading extension 'null': Reading manifest: Error processing permissions.4: Unknown permission "unlimitedStorage"
1507740751800        addons.webextension.{73a6fe31-595d-460b-a920-fcc0f8843232}        WARN        Loading extension '{73a6fe31-595d-460b-a920-fcc0f8843232}': Reading manifest: Error processing permissions.1: Unknown permission "privacy"
1507740751800        addons.webextension.{73a6fe31-595d-460b-a920-fcc0f8843232}        WARN        Loading extension '{73a6fe31-595d-460b-a920-fcc0f8843232}': Reading manifest: Error processing permissions.4: Unknown permission "unlimitedStorage"

and

noscript-tbb not found!
[10-11 17:02:22] Torbutton INFO: New window

which is an exclamation about the obvious thing :)

... none of which is a bug, despite the exclamation mark.

The exclamation is not a bug. NoScript's extension 'null' - it's not so obvious.

Update: it seems [System+Principal] doesn't work.

Work at what? The message about [System Principal] just takes note that there was a window where scripts could not be blocked because it had chrome privileges. It's normal, and nothing that needs to be "fixed".

That whitelist item doesn't suppress those messages.

Suggestion: please set the "noscript.consoleDump" preference to 0. If anything actually abnormal happens, you'll get messages in the browser console anyway.

Already set.

comment:30 Changed 13 months ago by cypherpunks

Tor Browser Team is offline during Montreal meeting (till next week?), so it's unknown how to sync with them :(
rc6 is much better than 5.1.1 anyway.
Just some residual quirks:

05:15:00.373 uri is undefined 1 MatchPattern.jsm:95	
	matches resource://gre/modules/MatchPattern.jsm:95:1
	matches/< resource://gre/modules/MatchPattern.jsm:118:42
	some self-hosted:208:1
	matches resource://gre/modules/MatchPattern.jsm:118:12
	urlMatches resource://gre/modules/WebRequestCommon.jsm:55:12
	shouldRunListener resource://gre/modules/WebRequest.jsm:549:12
	runChannelListener resource://gre/modules/WebRequest.jsm:692:14
	errorCheck resource://gre/modules/WebRequest.jsm:568:7
	runChannelListener resource://gre/modules/WebRequest.jsm:676:20
	onStopRequest resource://gre/modules/WebRequest.jsm:841:5
	onStopRequest resource://gre/modules/WebRequest.jsm:351:5
05:15:04.879 TypeError: Ci is undefined 1 Main.js:138:1	

(the next most annoying issue is #23747)

comment:31 in reply to:  30 Changed 13 months ago by ma1

Replying to cypherpunks:

rc6 is much better than 5.1.1 anyway

Thanks for testing it.

05:15:00.373 uri is undefined 1 MatchPattern.jsm:95        
matches resource://gre/modules/MatchPattern.jsm:95:1
matches/< resource://gre/modules/MatchPattern.jsm:118:42
some self-hosted:208:1
matches resource://gre/modules/MatchPattern.jsm:118:12
urlMatches resource://gre/modules/WebRequestCommon.jsm:55:12
shouldRunListener resource://gre/modules/WebRequest.jsm:549:12
runChannelListener resource://gre/modules/WebRequest.jsm:692:14
errorCheck resource://gre/modules/WebRequest.jsm:568:7
runChannelListener resource://gre/modules/WebRequest.jsm:676:20
onStopRequest resource://gre/modules/WebRequest.jsm:841:5
onStopRequest resource://gre/modules/WebRequest.jsm:351:5
05:15:04.879 TypeError: Ci is undefined 1 Main.js:138:1        

The MatchingPattern thing is surely not from NoScript, most likely from HTTPSEverywhere if it's already a WebExtension.

For the TypeError (which should happen only after a restartless upgrade/install/disablement) I'm implementing a work-around.

Looking into #23747, too.

comment:32 Changed 13 months ago by cypherpunks

Also take a look at #23397 ;)

comment:33 in reply to:  32 Changed 13 months ago by cypherpunks

Replying to ma1:

Replying to cypherpunks:

rc6 is much better than 5.1.1 anyway

Thanks for testing it.

rc7 would be a good number before release :)
TBB release next week. That means bundles will be available this weekend. So, probably, Friday is the right day for release, even without response from gk.

Looking into #23747, too.

Very good.

Replying to cypherpunks:

Also take a look at #23397 ;)

Oh, another cypherpunk, hello! Easy workaround was provided for you, so it's not so urgent. Feedback about pre-release versions of NoScript is welcome.

comment:34 in reply to:  29 Changed 13 months ago by cypherpunks

Let's assume NoScript was updated to 5.1.2 on gk's Tor Browser, and he will come to say some words here :)

Replying to ma1:

Update: it seems [System+Principal] doesn't work.

Work at what? The message about [System Principal] just takes note that there was a window where scripts could not be blocked because it had chrome privileges. It's normal, and nothing that needs to be "fixed".

That whitelist item doesn't suppress those messages.

this.mandatorySites.sitesString = this.getPref("mandatory", "chrome: about: resource: [System Principal]"); in Main.js seems to use " " as the pref does, so it works in the default NS config, but doesn't work if added manually with "+" sign.
Also shouldn't it contain moz-extension:? Maybe, it could fix #23322.
Candidate for whitelisting is #23736.

As for restartless updates, the correct documentation seems to be https://dxr.mozilla.org/mozilla-esr52/rev/efa03deffad75f19fc598a757239e99b22a8bceb/toolkit/mozapps/extensions/internal/XPIProvider.jsm#4865 as usual :( But some links from https://developer.mozilla.org/en-US/Add-ons/Bootstrapped_extensions are also useful and could be used for bootstrapped part refactoring in order to get the dialog box when disabling NoScript working, for example.

comment:35 Changed 13 months ago by cypherpunks

Found https://dxr.mozilla.org/mozilla-esr52/rev/efa03deffad75f19fc598a757239e99b22a8bceb/toolkit/mozapps/extensions/internal/XPIProvider.jsm#5764, which may affect the update process as TBB has that cache disabled.

No chrome package registered for chrome://noscript/skin/icon32.png is a leftover after shutdown bootstrap method and removal of manifest.
Also it's possible to trigger

No chrome package registered for chrome://noscript/content/UISync.jsm
NS_ERROR_FILE_NOT_FOUND: File error: Not found  UISync.jsm:32
08:40:31.268 TypeError: Ci is undefined 1 Main.js:1507:11
15:54:58.635 TypeError: p is null 1 Main.js:1182:5

Minor:

TypeError: ns is undefined MimeServiceParent.js:13:9
[NoScript XSS] xss.reason.URIError: malformed URI sequence --- InjectionChecker.checkHTML@chrome://noscript/content/InjectionChecker.js?1bsc7269keutfaq7v55o:831:73
InjectionChecker._checkRecursive@chrome://noscript/content/InjectionChecker.js?1bsc7269keutfaq7v55o:995:9
InjectionChecker._checkRecursive@chrome://noscript/content/InjectionChecker.js?1bsc7269keutfaq7v55o:1044:11
InjectionChecker.checkRecursive@chrome://noscript/content/InjectionChecker.js?1bsc7269keutfaq7v55o:990:12
InjectionChecker.checkURL@chrome://noscript/content/InjectionChecker.js?1bsc7269keutfaq7v55o:939:12
RequestWatchdog.prototype.filterXSS@chrome://noscript/content/RequestWatchdog.js?1bsc7269keutfaq7v55o:803:43
RequestWatchdog.prototype.onHttpStart/<@chrome://noscript/content/RequestWatchdog.js?1bsc7269keutfaq7v55o:158:18
DOSChecker.prototype.run@chrome://noscript/content/RequestWatchdog.js?1bsc7269keutfaq7v55o:1114:22
RequestWatchdog.prototype.onHttpStart@chrome://noscript/content/RequestWatchdog.js?1bsc7269keutfaq7v55o:156:9
MainParent["http-on-modify-request"].observe@chrome://noscript/content/MainParent.js?1bsc7269keutfaq7v55o:83:24
Last edited 13 months ago by cypherpunks (previous) (diff)

comment:36 Changed 13 months ago by cypherpunks

Although it's off-topic for Tor Browser, as it doesn't use additional NoScript buttons by default, but also worth mentioning: noscript-tbb is used in two more places (MainParent.js, Restartless.jsm) in the codebase than the other two buttons, which disappear.

Pearl Crescent, are you doing code review of changes between NoScript versions?

comment:37 in reply to:  36 Changed 13 months ago by mcs

Replying to cypherpunks:

Pearl Crescent, are you doing code review of changes between NoScript versions?

No. As a team we would need to decide whether the effort it would take to do so is worthwhile, because I suspect it would take someone quite a bit of time to some up to speed on the NoScript codebase.

comment:38 Changed 13 months ago by gk

Resolution: fixed
Status: needs_revisionclosed

Okay, it seems we are done in this bug here? Thanks to all who helped with that one.

comment:39 Changed 13 months ago by gk

Keywords: TorBrowserTeam201710 added
Note: See TracTickets for help on using tickets.