Opened 5 months ago

Closed 4 months ago

#23755 closed defect (fixed)

don't unconditionally mirror in .gitlab-ci.yml

Reported by: catalyst Owned by:
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version: Tor: 0.3.2.2-alpha
Severity: Normal Keywords: tor-ci continuous-integration
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

A few of us have experimented with using the .gitlab-ci.yml to run continuous integration jobs on gitlab.com and oniongit.eu. Right now they're failing in the "update" job because $DEPLOY_KEY isn't configured. At the very least we should make the job cleanly exit if the key is not configured.

Typical output from the "update" job:

$ eval $(ssh-agent -s)
Agent pid 4533
$ ssh-add <(echo "$DEPLOY_KEY")
Enter passphrase for /dev/fd/63: ERROR: Job failed: exit code 1

Child Tickets

Change History (3)

comment:1 Changed 5 months ago by catalyst

Version: Tor: 0.3.2.2-alpha

comment:2 Changed 5 months ago by catalyst

Status: newneeds_review
Summary: conditionalize mirroring script in .gitlab-ci.ymldon't unconditionally mirror in .gitlab-ci.yml

Patch in https://oniongit.eu/catalyst/tor/merge_requests/11 to do the minimum required to make gitlab.com CI useful on master. Additional improvements for the actual (non-mirroring) CI build job go in #23757.

comment:3 Changed 4 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged!

Note: See TracTickets for help on using tickets.