Opened 8 months ago

Closed 8 months ago

#23757 closed defect (fixed)

tor's .gitlab-ci.yml doesn't have the same behaviour as our .travis.yml

Reported by: isis Owned by: catalyst
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version: Tor: 0.3.2.2-alpha
Severity: Normal Keywords: tor-ci
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When new contributors come to us saying, "Hi, I made a patch, but the CI seems to be failing" it seems like a bad starting place to respond with "Which CI is failing?"

In #22891, it seemed like we were in agreement to have both our Gitlab CI and Travis CI do (as much as possible) the same things.

Child Tickets

Change History (4)

comment:1 Changed 8 months ago by catalyst

Maybe we should have helper scripts that can run in a variety of different CI environments with small parameter changes.

comment:2 Changed 8 months ago by catalyst

Owner: set to catalyst
Status: newaccepted

comment:3 Changed 8 months ago by catalyst

Status: acceptedneeds_review
Version: Tor: 0.3.1.3-alphaTor: 0.3.2.2-alpha

Patch in https://oniongit.eu/catalyst/tor/merge_requests/12
This includes the patch for #23755.

Additional work to refactor the Travis and GitLab CI configurations into shared scripts should be a different ticket.

comment:4 Changed 8 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged!

Note: See TracTickets for help on using tickets.