Opened 8 months ago

Last modified 6 weeks ago

#23759 assigned defect

Refactor common code out of setup_introduce1_data and intro point functions

Reported by: teor Owned by: dgoulet
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: prop224, tor-hs, single-onion, ipv6, refactor, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: #23493 Points:
Reviewer: Sponsor:

Description

During #23577, we discovered that there's a lot of code in setup_introduce1_data() that's duplicated in service_intro_point_new() and hs_desc_lspec_to_trunnel().

And in #23577, we want to copy more of it.

So we should clean that up at some point, but it's complicated, because the intro point functions use hs_desc_link_specifier_t.

Or we could add comments in the duplicate code to tell us to check the other functions when any one of them changes.

Child Tickets

Change History (6)

comment:1 Changed 6 months ago by teor

nickm says:
Someday, we should merge this function with the function that makes all the link specifiers for extend cells. (Okay to fix later.)

https://trac.torproject.org/projects/tor/ticket/23577#comment:21

comment:2 Changed 4 months ago by dgoulet

Owner: set to dgoulet
Status: newassigned

comment:3 Changed 4 months ago by dgoulet

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

Move 033 ticket I own to 034

comment:4 Changed 8 weeks ago by nickm

Keywords: 034-triage-20180328 added

comment:5 Changed 8 weeks ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:6 Changed 6 weeks ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Note: See TracTickets for help on using tickets.