Opened 3 years ago

Closed 17 months ago

#23759 closed defect (duplicate)

Refactor common code out of setup_introduce1_data and intro point functions

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor:
Severity: Normal Keywords: prop224, tor-hs, single-onion, ipv6, refactor, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points: 0.1
Parent ID: #23576 Points: 0.1
Reviewer: Sponsor:

Description (last modified by teor)

During #23577, we discovered that there's a lot of code in setup_introduce1_data() that's duplicated in service_intro_point_new() and hs_desc_lspec_to_trunnel().

In #23576, we removed the duplication across setup_introduce1_data() and service_intro_point_new(), creating node_get_link_specifier_smartlist().

So we should clean that up at some point, but it's complicated, because the intro point functions use hs_desc_link_specifier_t. (See #22781)

Edit: update after #23576.

Child Tickets

Change History (10)

comment:1 Changed 3 years ago by teor

nickm says:
Someday, we should merge this function with the function that makes all the link specifiers for extend cells. (Okay to fix later.)

comment:2 Changed 3 years ago by dgoulet

Owner: set to dgoulet
Status: newassigned

comment:3 Changed 3 years ago by dgoulet

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

Move 033 ticket I own to 034

comment:4 Changed 2 years ago by nickm

Keywords: 034-triage-20180328 added

comment:5 Changed 2 years ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:6 Changed 2 years ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

comment:7 Changed 2 years ago by teor

Parent ID: #23493#23576

We need this refactor for #23576.

comment:8 Changed 2 years ago by teor

Description: modified (diff)
Parent ID: #23576#22781

Oops, no we don't.

Fixing #23576 removes the duplication across setup_introduce1_data() and service_intro_point_new().

comment:9 Changed 19 months ago by teor

Actual Points: 0.1
Owner: changed from dgoulet to teor
Parent ID: #22781#23576
Points: 0.1
Version: Tor:

This is fixed in #23576.

comment:10 Changed 17 months ago by teor

Resolution: duplicate
Status: assignedclosed
Note: See TracTickets for help on using tickets.