Refactor common code out of setup_introduce1_data and intro point functions

During #23577 (moved), we discovered that there's a lot of code in setup_introduce1_data() that's duplicated in service_intro_point_new() and hs_desc_lspec_to_trunnel().

In #23576 (moved), we removed the duplication across setup_introduce1_data() and service_intro_point_new(), creating node_get_link_specifier_smartlist().

So we should clean that up at some point, but it's complicated, because the intro point functions use hs_desc_link_specifier_t. (See #22781 (moved))

Edit: update after #23576 (moved).

changed milestone to %Tor: unspecified

added 034-removed-20180328 034-triage-20180328 actualpoints::0.1 component::core tor/tor ipv6 milestone::Tor: unspecified owner::teor parent::23576 points::0.1 priority::medium prop224 refactor resolution::duplicate severity::normal single-onion status::closed tor-hs type::defect version::tor 0.3.2.1-alpha labels

nickm says: Someday, we should merge this function with the function that makes all the link specifiers for extend cells. (Okay to fix later.)

https://trac.torproject.org/projects/tor/ticket/23577#comment:21

Trac:
Status: new to assigned
Owner: N/A to dgoulet

Move 033 ticket I own to 034

Trac:
Milestone: Tor: 0.3.3.x-final to Tor: 0.3.4.x-final

Trac:
Keywords: N/A deleted, 034-triage-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

Trac:
Keywords: N/A deleted, 034-removed-20180328 added

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Trac:
Milestone: Tor: 0.3.4.x-final to Tor: unspecified

We need this refactor for #23576 (moved).

Trac:
Parent: #23493 (moved) to #23576 (moved)

Oops, no we don't.

Fixing #23576 (moved) removes the duplication across setup_introduce1_data() and service_intro_point_new().

Trac:
Parent: #23576 (moved) to #22781 (moved)
Description: During #23577 (moved), we discovered that there's a lot of code in setup_introduce1_data() that's duplicated in service_intro_point_new() and hs_desc_lspec_to_trunnel().

And in #23577 (moved), we want to copy more of it.

So we should clean that up at some point, but it's complicated, because the intro point functions use hs_desc_link_specifier_t.

Or we could add comments in the duplicate code to tell us to check the other functions when any one of them changes.

to

During #23577 (moved), we discovered that there's a lot of code in setup_introduce1_data() that's duplicated in service_intro_point_new() and hs_desc_lspec_to_trunnel().

In #23576 (moved), we removed the duplication across setup_introduce1_data() and service_intro_point_new(), creating node_get_link_specifier_smartlist().

So we should clean that up at some point, but it's complicated, because the intro point functions use hs_desc_link_specifier_t. (See #22781 (moved))

Edit: update after #23576 (moved).

This is fixed in #23576 (moved).

Trac:
Version: N/A to Tor: 0.3.2.1-alpha
Parent: #22781 (moved) to #23576 (moved)
Points: N/A to 0.1
Actualpoints: N/A to 0.1
Owner: dgoulet to teor

Trac:
Resolution: N/A to duplicate
Status: assigned to closed

closed

changed time estimate to 48m

added 48m of time spent

moved to tpo/core/tor#23759 (closed)