Changes between Initial Version and Version 1 of Ticket #23764, comment 6


Ignore:
Timestamp:
Nov 3, 2017, 12:35:39 PM (2 years ago)
Author:
asn
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23764, comment 6

    initial v1  
    11BTW here is an example of a thing that might go bad (and the suggested tests above would not catch):
    22
    3 `get_voting_interval()` and `hs_get_time_period_num()` all use `networkstatus_get_live_consensus()` and are used both by clients and services in multiple places. If a live consensus is not found those functions have an alternative behavior, and if we do the suggested change here we could be using this alternative behavior more frequently. We should make sure that this won't cause any reachability issues.
     3`get_voting_interval()` and `hs_get_time_period_num()` and `hs_in_period_between_tp_and_srv()` all use `networkstatus_get_live_consensus()` and are used both by clients and services in multiple places. If a live consensus is not found those functions have an alternative behavior, and if we do the suggested change here we could be using this alternative behavior more frequently. We should make sure that this won't cause any reachability issues.