Update code to wipe indexedDB in New Identity

Looks like Mozilla may have fixed the issue of wiping indexedDB.

https://bugzilla.mozilla.org/show_bug.cgi?id=1047098

Let's see if we can get this working in New Identity.

added component::applications/tor browser gitlab-tb-torbutton owner::tbb-team priority::medium severity::normal status::new tbb-linkability tbb-newnym tbb-torbutton type::defect labels

Trac:
Summary: Wipe indexeDB in New Identity to Wipe indexedDB in New Identity
Keywords: N/A deleted, tbb-linkability added

Replying to arthuredelstein:

Looks like Mozilla may have fixed the issue of wiping indexedDB.

https://bugzilla.mozilla.org/show_bug.cgi?id=1405884

It seems that's not the bug number you had in mind. Which was it then?

Trac:
Keywords: N/A deleted, tbb-newnym added

Trac:
Status: new to needs_information

I guess you meant: https://bugzilla.mozilla.org/show_bug.cgi?id=1047098.

Replying to gk:

Replying to arthuredelstein:

Looks like Mozilla may have fixed the issue of wiping indexedDB.

https://bugzilla.mozilla.org/show_bug.cgi?id=1405884

It seems that's not the bug number you had in mind. Which was it then? Probably, both, because tbb-linkability is for this bug number, not for this ticket.

Replying to cypherpunks: No ni.

Trac:
Status: needs_information to new

Replying to gk:

I guess you meant: https://bugzilla.mozilla.org/show_bug.cgi?id=1047098.

Yeah, sorry, that's the one I meant. I am editing the description.

Trac:
Description: Looks like Mozilla may have fixed the issue of wiping indexedDB.

https://bugzilla.mozilla.org/show_bug.cgi?id=1405884

Let's see if we can get this working in New Identity.

to

Looks like Mozilla may have fixed the issue of wiping indexedDB.

https://bugzilla.mozilla.org/show_bug.cgi?id=1047098

Let's see if we can get this working in New Identity.

I did an experiment and found that Tor Browser already wipes indexedDB on New Identity.

I think the relevant code is here: https://gitweb.torproject.org/torbutton.git/tree/src/chrome/content/torbutton.js?id=b3ff9863db338b2bd612f109e8bbce4c4af7cbd0#n1151

  let orig_quota_test = m_tb_prefs.getBoolPref("dom.quotaManager.testing");
  try {
      // This works only by setting the pref to `true` otherwise we get an
      // exception and nothing is happening.
      m_tb_prefs.setBoolPref("dom.quotaManager.testing", true);
      Cc["@mozilla.org/dom/quota-manager-service;1"]
          .getService(Ci.nsIQuotaManagerService).clear();
  } catch(e) {
      torbutton_log(5, "Exception on storage clearing: "+e);
  } finally {
      m_tb_prefs.setBoolPref("dom.quotaManager.testing", orig_quota_test);
  }

Unfortunately, it's a little hacky because we are having to set the "dom.quotaManager.testing" pref. Maybe it would be better to adopt the code from https://hg.mozilla.org/mozilla-central/rev/0fbe00ad0203#l1.42.

Trac:
Summary: Wipe indexedDB in New Identity to Update code to wipe indexedDB in New Identity

Trac:
Username: tokotoko
Cc: N/A to fdsfgs@krutt.org

tbb-torbutton, TorBrowserTeam201809

Replying to arthuredelstein:

Unfortunately, it's a little hacky because we are having to set the "dom.quotaManager.testing" pref. And to somehow check for https://dxr.mozilla.org/mozilla-esr60/rev/dd52b41d2b775e5c7261ce52795268b7670635fc/dom/quota/ActorsParent.cpp#2712 Maybe it would be better to adopt the code from https://hg.mozilla.org/mozilla-central/rev/0fbe00ad0203#l1.42. It is now in TB 8.0.

Trac:
Username: 1-hop

Trac:
Keywords: N/A deleted, gitlab-tb-torbutton, tbb-torbutton added

moved to tpo/applications/torbutton#23768 (moved)