Opened 9 years ago

Closed 8 years ago

Last modified 7 years ago

#2378 closed defect (fixed)

Detect failed allocations from openssl

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We don't check openssl allocation functions for non-NULL return values everywhere in crypto.c and tortls.c as we should. Noted by "cypherpunks" in a comment on bug #2352.

Child Tickets

Change History (4)

comment:1 Changed 8 years ago by nickm

Status: newneeds_review

Fixed all the ones I could find in branch bug2378 in my public repository.

comment:2 Changed 8 years ago by Sebastian

I had a look around both files too, didn't spot anything you missed. Maybe cypherpunks finds more?

comment:3 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Had another look, didn't see anything else. Merging & closing for now.

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.